Differential D7079

Fixup comment regarding finalized block
ClosedPublic
Actions

Authored by jasonbcox on Jul 29 2020, 16:56.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCf1195918a674: Fixup comment regarding finalized block

Summary

The comment isn't technically correct, as direct user action via the RPC
can reorg the finalized block. This patch clarifies that.

Test Plan

Read it.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

finalized-block-comment

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12222
Build 24646: Default Diff Build & Tests	build-diff
Build 24645: Build without Wallet	build-without-wallet
Build 24644: Build with clang-10	build-clang-10
Build 24643: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 29 2020, 16:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 29 2020, 16:56

jasonbcox requested review of this revision.Jul 29 2020, 16:56

Harbormaster completed remote builds in B12222: Diff 22609.Jul 29 2020, 17:08

majcosta accepted this revision.Jul 29 2020, 17:56

This revision is now accepted and ready to land.Jul 29 2020, 17:56

Closed by commit rABCf1195918a674: Fixup comment regarding finalized block (authored by jasonbcox). · Explain WhyJul 29 2020, 22:20

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCf1195918a674: Fixup comment regarding finalized block.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

2 lines

Diff 22609

View Options

Fixup comment regarding finalized blockClosedPublicActions