Differential D7124

warning prefix for GUI messages
ClosedPublic
Actions

Authored by majcosta on Aug 4 2020, 15:39.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC564f890228a4: [backport#15894 1/3] Prepend the error/warning prefix for GUI messages

Summary

https://github.com/bitcoin/bitcoin/pull/15894/commits/f0641f274ffe94fbe7cae43c07a9373013739df2

Partial backport of Core PR15894

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12299
Build 24801: Build Diff	build-without-wallet · build-clang-10 · build-clang-tidy · build-diff
Build 24800: arc lint + arc unit

Event Timeline

majcosta created this revision.Aug 4 2020, 15:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 4 2020, 15:39

majcosta requested review of this revision.Aug 4 2020, 15:39

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7125: [backport#15894 2/3] Add MSG_NOPREFIX flag for user messages.Aug 4 2020, 15:43

Harbormaster completed remote builds in B12299: Diff 22732.Aug 4 2020, 15:51

jasonbcox accepted this revision.Aug 4 2020, 21:27

This revision is now accepted and ready to land.Aug 4 2020, 21:27

Closed by commit rABC564f890228a4: [backport#15894 1/3] Prepend the error/warning prefix for GUI messages (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by majcosta). · Explain WhyAug 5 2020, 04:59

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC564f890228a4: [backport#15894 1/3] Prepend the error/warning prefix for GUI messages.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoingui.h

4 lines

bitcoingui.cpp

14 lines

Diff 22732

View Options

src/qt/bitcoingui.h