Differential D7267

Add more flexibility to the update-aur.sh script
ClosedPublic
Actions

Authored by Fabien on Aug 28 2020, 11:08.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC3a121af5f10c: Add more flexibility to the update-aur.sh script

Summary

This diffs makes the script to update a single package at a time, and
take an optional commit message to replace the default version/release
bump message.

Test Plan

Comment the final push, then:
Should fail:

./update-aur.sh
./update-aur.sh this has too many arguments

Should succeed:

./update-aur.sh bitcoin-abc
./update-aur.sh bitcoin-abc "my commit message"

Check that the commit message is the one passed on the command line.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

aur_commit_message

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12490
Build 25121: Build Diff	build-diff · build-clang-tidy · build-clang-10 · build-without-wallet
Build 25120: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 28 2020, 11:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2020, 11:08

Fabien requested review of this revision.Aug 28 2020, 11:08

Harbormaster completed remote builds in B12490: Diff 23073.Aug 28 2020, 11:29

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[0m[0;32mrpc_estimatefee.py                      | ✓ Passed  | 1 s
[0m[0;32mrpc_getblockfilter.py                   | ✓ Passed  | 1 s
[0m[0;32mrpc_getblockstats.py                    | ✓ Passed  | 1 s
[0m[0;32mrpc_getchaintips.py                     | ✓ Passed  | 1 s
[0m[0;32mrpc_help.py                             | ✓ Passed  | 1 s
[0m[0;32mrpc_invalidateblock.py                  | ✓ Passed  | 6 s
[0m[0;32mrpc_misc.py                             | ✓ Passed  | 1 s
[0m[0;32mrpc_named_arguments.py                  | ✓ Passed  | 1 s
[0m[0;32mrpc_net.py                              | ✓ Passed  | 1 s
[0m[0;32mrpc_preciousblock.py                    | ✓ Passed  | 1 s
[0m[0;32mrpc_psbt.py                             | ✓ Passed  | 22 s
[0m[0;32mrpc_scantxoutset.py                     | ✓ Passed  | 5 s
[0m[0;32mrpc_setban.py                           | ✓ Passed  | 2 s
[0m[0;32mrpc_signmessage.py                      | ✓ Passed  | 1 s
[0m[0;32mrpc_signrawtransaction.py               | ✓ Passed  | 2 s
[0m[0;32mrpc_txoutproof.py                       | ✓ Passed  | 2 s
[0m[0;32mrpc_uptime.py                           | ✓ Passed  | 1 s
[0m[0;32mrpc_users.py                            | ✓ Passed  | 2 s
[0m[0;32mrpc_whitelist.py                        | ✓ Passed  | 1 s
[0m[0;32mtool_wallet.py                          | ✓ Passed  | 3 s
[0m[0;32mwallet_abandonconflict.py               | ✓ Passed  | 10 s
[0m[0;32mwallet_address_types.py                 | ✓ Passed  | 16 s
[0m[0;32mwallet_avoidreuse.py                    | ✓ Passed  | 3 s
[0m[0;32mwallet_balance.py                       | ✓ Passed  | 17 s
[0m[0;32mwallet_basic.py                         | ✓ Passed  | 34 s
[0m[0;32mwallet_create_tx.py                     | ✓ Passed  | 7 s
[0m[0;32mwallet_createwallet.py                  | ✓ Passed  | 3 s
[0m[0;32mwallet_createwallet.py --usecli         | ✓ Passed  | 3 s
[0m[0;32mwallet_disable.py                       | ✓ Passed  | 0 s
[0m[0;32mwallet_dump.py                          | ✓ Passed  | 2 s
[0m[0;32mwallet_encryption.py                    | ✓ Passed  | 6 s
[0m[0;32mwallet_groups.py                        | ✓ Passed  | 10 s
[0m[0;32mwallet_hd.py                            | ✓ Passed  | 5 s
[0m[0;32mwallet_import_rescan.py                 | ✓ Passed  | 4 s
[0m[0;32mwallet_import_with_label.py             | ✓ Passed  | 1 s
[0m[0;32mwallet_importmulti.py                   | ✓ Passed  | 3 s
[0m[0;32mwallet_importprunedfunds.py             | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool.py                       | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool_topup.py                 | ✓ Passed  | 3 s
[0m[0;32mwallet_labels.py                        | ✓ Passed  | 1 s
[0m[0;32mwallet_listreceivedby.py                | ✓ Passed  | 8 s
[0m[0;32mwallet_listsinceblock.py                | ✓ Passed  | 4 s
[0m[0;32mwallet_listtransactions.py              | ✓ Passed  | 14 s
[0m[0;32mwallet_multiwallet.py                   | ✓ Passed  | 17 s
[0m[0;32mwallet_multiwallet.py --usecli          | ✓ Passed  | 21 s
[0m[0;32mwallet_reorgsrestore.py                 | ✓ Passed  | 3 s
[0m[0;32mwallet_resendwallettransactions.py      | ✓ Passed  | 34 s
[0m[0;32mwallet_txn_clone.py                     | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py               | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_doublespend.py --mineblock   | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py                     | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli            | ✓ Passed  | 2 s
[0m[0;32mwallet_zapwallettxes.py                 | ✓ Passed  | 3 s
[0m[1m
ALL                                     | ✓ Passed  | 679 s (accumulated) 
[0mRuntime: 136 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: wallet_listtransactions.py

jasonbcox accepted this revision.Aug 28 2020, 16:52

This revision is now accepted and ready to land.Aug 28 2020, 16:52

This revision was landed with ongoing or failed builds.Aug 28 2020, 18:45

Closed by commit rABC3a121af5f10c: Add more flexibility to the update-aur.sh script (authored by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3a121af5f10c: Add more flexibility to the update-aur.sh script.