Update AUR package to 0.22.1
ClosedPublic
Actions

Authored by Fabien on Sep 2 2020, 10:08.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC92373274d19d: Update AUR package to 0.22.1

Summary

Also includes a few improvements:

Declare bitcoin-wallet as a provided binary for the qt package (which has the wallet enabled).
Use the ninja install/strip rule rather than installing each component individually now that secp256k1 is no longer installed by default.
Reenable ninja check which is now fixed (used to segfault due to setlocale).

Depends on D7305 and D7306.

Test Plan

Comment out the git push line in the update-aur.sh script, and run
it as root:

./update-aur bitcoin-abc
./update-aur bitcoin-abc-qt

Repository

rABC Bitcoin ABC

Branch

aur_0_22_1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12547
Build 25213: Build Diff	build-without-wallet · build-diff · build-clang-10 · build-clang-tidy
Build 25212: arc lint + arc unit

Fabien requested review of this revision.Sep 2 2020, 10:08

Fabien edited the summary of this revision. (Show Details)Sep 2 2020, 10:08

deadalnix requested changes to this revision.Sep 2 2020, 13:20

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

contrib/aur/bitcoin-abc-qt/PKGBUILD
4	Can't this be generated? If not, then it needs to be added to the checklist of thing for which the version needs to be updated. But ultimately, auto-filling this, is the best route.

This revision now requires changes to proceed.Sep 2 2020, 13:20

Fabien requested review of this revision.Sep 2 2020, 13:34

Fabien added inline comments.

contrib/aur/bitcoin-abc-qt/PKGBUILD
4	Absolutely, it's going to be generated for each release. This will be the next step, I first need to check that the other parts of the automation are working (this diff should update the AUR package automatically when landed). This should be the only time the version is updated manually. There already is a point in the release process, which is going to be outdated by this new workflow and will be removed very soon.