Differential D7311

[CI] Move some more path definitions to the Configuration object
ClosedPublic
Actions

Authored by Fabien on Sep 2 2020, 14:40.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC8bd40e974268: [CI] Move some more path definitions to the Configuration object

Summary

D7310 made the project root part of the configuration object, as it is
independent of the build context (Teamcity or user machine). The build
directory is also context independent, and the same applies to most of
its subdirectories. Only the artifact directory location needs to be
adapted depending on the context.

This diff moves the build directory path definition to the Configuration
object, as well as its subdirectories. The rational is the same than for
the project root, it allow to derive the paths to construct the build
steps from the configuration.

There is no change in behavior.

Depends on D7310.

Test Plan

Run any CI build.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ci_move_dirs_to_config

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12562
Build 25240: Build Diff	build-clang-tidy · build-diff · build-clang-10 · build-without-wallet
Build 25239: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 2 2020, 14:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 2 2020, 14:40

Fabien requested review of this revision.Sep 2 2020, 14:40

Harbormaster completed remote builds in B12551: Diff 23168.Sep 2 2020, 15:01

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Snippet of first build failure:

[0m[1;30mwallet_createwallet.py --usecli         | ○ Skipped | 0 s
[0m[1;30mwallet_dump.py                          | ○ Skipped | 0 s
[0m[1;30mwallet_encryption.py                    | ○ Skipped | 0 s
[0m[1;30mwallet_groups.py                        | ○ Skipped | 0 s
[0m[1;30mwallet_hd.py                            | ○ Skipped | 0 s
[0m[1;30mwallet_import_rescan.py                 | ○ Skipped | 0 s
[0m[1;30mwallet_import_with_label.py             | ○ Skipped | 0 s
[0m[1;30mwallet_importmulti.py                   | ○ Skipped | 0 s
[0m[1;30mwallet_importprunedfunds.py             | ○ Skipped | 0 s
[0m[1;30mwallet_keypool.py                       | ○ Skipped | 0 s
[0m[1;30mwallet_keypool_topup.py                 | ○ Skipped | 0 s
[0m[1;30mwallet_labels.py                        | ○ Skipped | 0 s
[0m[1;30mwallet_listreceivedby.py                | ○ Skipped | 0 s
[0m[1;30mwallet_listsinceblock.py                | ○ Skipped | 0 s
[0m[1;30mwallet_listtransactions.py              | ○ Skipped | 0 s
[0m[1;30mwallet_multiwallet.py                   | ○ Skipped | 0 s
[0m[1;30mwallet_multiwallet.py --usecli          | ○ Skipped | 0 s
[0m[1;30mwallet_reorgsrestore.py                 | ○ Skipped | 0 s
[0m[1;30mwallet_resendwallettransactions.py      | ○ Skipped | 0 s
[0m[1;30mwallet_txn_clone.py                     | ○ Skipped | 0 s
[0m[1;30mwallet_txn_clone.py --mineblock         | ○ Skipped | 0 s
[0m[1;30mwallet_txn_doublespend.py               | ○ Skipped | 0 s
[0m[1;30mwallet_txn_doublespend.py --mineblock   | ○ Skipped | 0 s
[0m[1;30mwallet_watchonly.py                     | ○ Skipped | 0 s
[0m[1;30mwallet_watchonly.py --usecli            | ○ Skipped | 0 s
[0m[1;30mwallet_zapwallettxes.py                 | ○ Skipped | 0 s
[0m[0;31minterface_zmq.py                        | ✖ Failed  | 64 s
[0m[0;31m[1m
ALL                                     | ✖ Failed  | 314 s (accumulated) 
[0m[0mRuntime: 88 s

[150/373] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.005s

OK
[151/373] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[160/373] Running pow test suite
PASSED: pow test suite
[166/373] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[168/373] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:541:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 BOOST_AUTO_TEST_CASE(script_build) {
                      ^~~~~~~~~~~~
[372/373] Running bitcoin test suite
PASSED: bitcoin test suite
FAILED: test/CMakeFiles/check-functional 
cd /work/abc-ci-builds/build-without-wallet/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /usr/bin/python3.7 ./functional/test_runner.py "--testsuitename=Bitcoin ABC functional tests" --junitoutput=/work/abc-ci-builds/build-without-wallet/test/junit/functional_tests.xml
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: interface_zmq.py

jasonbcox accepted this revision.Sep 2 2020, 17:57

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.