Page MenuHomePhabricator
Differential D7327

[backport#15390] [wallet-tool] Close bdb when flushing wallet
ClosedPublic
Actions

Authored by majcosta on Sep 2 2020, 21:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC7478bfcdabd3: [backport#15390] [wallet-tool] Close bdb when flushing wallet
Summary

[wallet] Close bdb when flushing wallet. (John Newbery)

Pull request description:

bdb would not be closed when closing the wallet in wallet-tool. Fix this by calling wallet->flush with true.

Backport of Core PR15390

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Sep 2 2020, 21:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 2 2020, 21:32
majcosta requested review of this revision.Sep 2 2020, 21:32
teamcity edited the summary of this revision. (Show Details)Sep 2 2020, 21:37

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Sep 2 2020, 23:35
deadalnix added a subscriber: deadalnix.

The commit you point to is wrong.

When you backport a full PR, you don't need to link to the commit, just let the bot do its thing.

This revision now requires changes to proceed.Sep 2 2020, 23:35
majcosta requested review of this revision.Sep 2 2020, 23:47
majcosta edited the summary of this revision. (Show Details)

removed wrong commit link

deadalnix accepted this revision.Sep 3 2020, 00:08
This revision is now accepted and ready to land.Sep 3 2020, 00:08
This revision was landed with ongoing or failed builds.Sep 3 2020, 00:53
Closed by commit rABC7478bfcdabd3: [backport#15390] [wallet-tool] Close bdb when flushing wallet (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain Why
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC7478bfcdabd3: [backport#15390] [wallet-tool] Close bdb when flushing wallet.

Revision Contents
Changeset List

PathSize
src/
wallet/
6 lines

Diff 23213

View Options

src/wallet/wallettool.cpp

Loading...