Reduce noise in check-source-control-tools
ClosedPublic
Actions

Authored by jasonbcox on Sep 4 2020, 02:25.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf0b9203e65bd: Reduce noise in check-source-control-tools

Summary

Currently, autopatch.sh may output errors which are expected while running
some of these tests. However, only the error code is checked and the output is not
necessary to capture. We can just ignore it and remove some noisy "Error: ..." style
output from showing even when the tests pass.

Test Plan

cmake -GNinja -DBUILD_SOURCE_CONTROL_TOOLS=ON ..
ninja check-source-control-tools

Diff Detail

Repository

rABC Bitcoin ABC

Branch

less-noise

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12611
Build 25327: Build Diff	build-without-wallet · build-diff · build-clang-tidy · build-clang-10
Build 25326: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Sep 4 2020, 02:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2020, 02:25

jasonbcox requested review of this revision.Sep 4 2020, 02:25

Harbormaster completed remote builds in B12611: Diff 23282.Sep 4 2020, 03:02

Fabien accepted this revision.Sep 4 2020, 06:29

This revision is now accepted and ready to land.Sep 4 2020, 06:29

Closed by commit rABCf0b9203e65bd: Reduce noise in check-source-control-tools (authored by jasonbcox). · Explain WhySep 4 2020, 17:57

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCf0b9203e65bd: Reduce noise in check-source-control-tools.

Revision Contents
Changeset List

Path

Size

contrib/

source-control-tools/

test/

test-autopatch.sh

2 lines

Diff 23282

View Options

contrib/source-control-tools/test/test-autopatch.sh

Reduce noise in check-source-control-toolsClosedPublicActions