Page MenuHomePhabricator
Differential D7378

[backport#16866] wallet: Rename 'decode' argument in gettransaction method to 'verbose'
ClosedPublic
Actions

Authored by majcosta on Sep 5 2020, 21:59.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC567961d85770: [backport#16866] wallet: Rename 'decode' argument in gettransaction method to…
Summary

[wallet] Rename 'decode' argument in gettransaction method to 'verbose' (John Newbery)

Pull request description:

This makes the RPC method consistent with other RPC methods that have a
'verbose' option.

Change the name of the return object from 'decoded' to details.

Update help text.

Backport of Core PR16866 and PR16873 (required to unbreak PR16866)

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr16866
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12642
Build 25385: Build Diff
Build 25384: arc lint + arc unit

Event Timeline

majcosta created this revision.Sep 5 2020, 21:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2020, 22:00
majcosta requested review of this revision.Sep 5 2020, 22:00
teamcity edited the summary of this revision. (Show Details)Sep 5 2020, 22:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Sep 5 2020, 23:12
This revision is now accepted and ready to land.Sep 5 2020, 23:12
This revision was landed with ongoing or failed builds.Sep 7 2020, 15:02
Closed by commit rABC567961d85770: [backport#16866] wallet: Rename 'decode' argument in gettransaction method to… (authored by Samuel Dobson <dobsonsa68@gmail.com>, committed by majcosta). · Explain Why
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC567961d85770: [backport#16866] wallet: Rename 'decode' argument in gettransaction method to….

Revision Contents
Changeset List

PathSize
doc/
5 lines
src/
rpc/
2 lines
wallet/
17 lines
test/
functional/
50 lines

Diff 23337

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/wallet_basic.py

Loading...