Differential D7379

[CI] Automated commits: fix ninja not running from the build directory
ClosedPublic
Actions

Authored by Fabien on Sep 7 2020, 09:54.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC03c44a46679f: [CI] Automated commits: fix ninja not running from the build directory

Summary

This was missed during testing because I tested the script from a build
directory. The CI doesn't, which causes ninja to fail due to missing
ninja.build file.

Test Plan

cd contrib/source-control-tools
COMMIT_TYPE=archive-release-notes ./automated-commits.sh

Diff Detail

Repository

rABC Bitcoin ABC

Branch

automated_commits_ninja_build_dir

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12643
Build 25387: Build Diff	build-without-wallet · build-clang-10 · build-clang-tidy · build-diff
Build 25386: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 7 2020, 09:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 7 2020, 09:54

Fabien requested review of this revision.Sep 7 2020, 09:54

Harbormaster completed remote builds in B12643: Diff 23340.Sep 7 2020, 10:12

deadalnix accepted this revision.Sep 7 2020, 18:00

This revision is now accepted and ready to land.Sep 7 2020, 18:00

Closed by commit rABC03c44a46679f: [CI] Automated commits: fix ninja not running from the build directory (authored by Fabien). · Explain WhySep 7 2020, 20:16

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC03c44a46679f: [CI] Automated commits: fix ninja not running from the build directory.

Revision Contents
Changeset List

Path

Size

contrib/

source-control-tools/

automated-commits.sh

16 lines

Diff 23340

View Options

contrib/source-control-tools/automated-commits.sh

[CI] Automated commits: fix ninja not running from the build directoryClosedPublicActions