Page MenuHomePhabricator

[CMAKE] Exclude the man pages from the install-debug target
ClosedPublic

Authored by Fabien on Sep 16 2020, 12:59.

Details

Summary

The man pages are now generated, and no longer part of the default
install target. This diff forwards the exclusion to the install-debug
target, since there is nothing to strip in a man page.

This has the side effect of removing the manpages from the Linux and
Windows Gitian builds, which is a good thing because the generation
process involves running the binary to extract the help, and this is not
always possible when cross compiling. The diff also removes the manpages
from the OSX Gitian build, for the same reason.

Test Plan
ninja install-debug

Check the manpages are not installed.
Run the gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_man_exclude_from_all
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12744
Build 25571: Build Diffbuild-diff · build-clang-tidy · build-clang-10 · build-without-wallet
Build 25570: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Sep 16 2020, 12:59
deadalnix added a subscriber: deadalnix.

There are manpages in tree, you probably want to clean this up.

This revision is now accepted and ready to land.Sep 16 2020, 15:26