Page MenuHomePhabricator
Differential D7600

Use preprocessor macros instead of autoconf to detect endianness
ClosedPublic
Actions

Authored by deadalnix on Sep 27 2020, 23:18.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC59ff26421523: Use preprocessor macros instead of autoconf to detect endianness
Summary

This does not fix any particular issue but it's preferable to not
rely on autoconf. This avoids endianness mess for users on BE hosts
if they use their build without autoconf.

The macros are carefully written to err on the side of the caution,
e.g., we #error if the user manually configures a different endianness
than what we detect.

This is a backport of secp256k1 PR787

Test Plan
ninja check-secp256k1

Diff Detail

Event Timeline

deadalnix created this revision.Sep 27 2020, 23:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2020, 23:18
deadalnix requested review of this revision.Sep 27 2020, 23:18
teamcity edited the summary of this revision. (Show Details)Sep 27 2020, 23:18

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta accepted this revision.Sep 27 2020, 23:22
This revision is now accepted and ready to land.Sep 27 2020, 23:22
This revision was landed with ongoing or failed builds.Sep 27 2020, 23:23
Closed by commit rABC59ff26421523: Use preprocessor macros instead of autoconf to detect endianness (authored by Tim Ruffing <crypto@timruffing.de>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC59ff26421523: Use preprocessor macros instead of autoconf to detect endianness.
Harbormaster completed remote builds in B12966: Diff 23870.Sep 27 2020, 23:41

Revision Contents
Changeset List

PathSize
src/
secp256k1/
2 lines
src/
5 lines
14 lines

Diff 23870

View Options

src/secp256k1/configure.ac

Loading...
View Options

src/secp256k1/src/hash_impl.h

Loading...
View Options

src/secp256k1/src/util.h

Loading...