Page MenuHomePhabricator

REST: add "blockhashbyheight" call, fetch blockhash by height
ClosedPublic

Authored by PiRK on Sep 30 2020, 13:56.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC488bfc24b6bd: REST: add "blockhashbyheight" call, fetch blockhash by height
Summary

[QA] add rest tests for /rest/blockhashbyheight/<HEIGHT>.<FORMAT>
[Docs] add short documentation for /rest/blockhashbyheight

This is a backport of Core PR14353

Test Plan

ninja && ninja check-functional

Diff Detail

Event Timeline

Owners added a reviewer: Restricted Owners Package.Sep 30 2020, 13:56
PiRK requested review of this revision.Sep 30 2020, 13:56

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

fix problems (backports not done sequentially for rest.cpp)

Snippet of first build failure:

-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[316/484] Building CXX object src/CMakeFiles/util.dir/util/error.cpp.o
[317/484] Building CXX object src/CMakeFiles/util.dir/rpc/request.cpp.o
[318/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[319/484] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[320/484] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[321/484] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[322/484] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[323/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[324/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[325/484] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[326/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[327/484] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[328/484] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[329/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[330/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[331/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[332/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[333/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[334/484] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[335/484] Linking CXX static library src/libutil.a
[336/484] Linking CXX static library src/libscript.a
[337/484] Linking CXX static library src/libcommon.a
[338/484] Linking CXX static library src/librpcclient.a
[339/484] Linking CXX executable src/bitcoin-cli
[340/484] Linking CXX static library src/libbitcoinconsensus.a
[341/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[342/484] Linking CXX shared library src/libbitcoinconsensus.so.0.22.4
[343/484] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[344/484] Linking CXX executable src/bitcoin-tx
[345/484] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[346/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[347/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[348/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/psbtwallet.cpp.o
[349/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[350/484] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[351/484] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[352/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[353/484] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[354/484] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[355/484] Linking CXX static library src/seeder/libseeder.a
[356/484] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[357/484] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[358/484] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[359/484] Linking CXX static library src/zmq/libzmq.a
[360/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[361/484] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[362/484] Linking CXX executable src/seeder/bitcoin-seeder
[363/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[364/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[365/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[366/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[367/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[368/484] Linking CXX static library src/wallet/libwallet.a
[369/484] Linking CXX static library src/wallet/libwallet-tool.a
[370/484] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Snippet of first build failure:

[312/482] Building CXX object src/CMakeFiles/util.dir/rpc/request.cpp.o
[313/482] Linking C executable src/secp256k1/sign-bench
[314/482] Linking C executable src/secp256k1/verify-bench
[315/482] Linking C executable src/secp256k1/recover-bench
[316/482] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[317/482] Building CXX object src/CMakeFiles/util.dir/util/error.cpp.o
[318/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[319/482] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[320/482] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[321/482] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[322/482] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[323/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[324/482] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[325/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[326/482] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[327/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[328/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[329/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[330/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[331/482] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[332/482] Linking CXX static library src/libutil.a
[333/482] Linking CXX static library src/libscript.a
[334/482] Linking CXX static library src/libcommon.a
[335/482] Linking CXX static library src/librpcclient.a
[336/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[337/482] Linking CXX executable src/bitcoin-cli
[338/482] Linking CXX static library src/libbitcoinconsensus.a
[339/482] Linking CXX shared library src/libbitcoinconsensus.so.0.22.4
[340/482] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[341/482] Linking CXX executable src/bitcoin-tx
[342/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[343/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[344/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[345/482] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[346/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[347/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[348/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[349/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[350/482] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[351/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/psbtwallet.cpp.o
[352/482] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[353/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[354/482] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[355/482] Linking CXX static library src/seeder/libseeder.a
[356/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[357/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[358/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[359/482] Linking CXX static library src/zmq/libzmq.a
[360/482] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[361/482] Linking CXX executable src/seeder/bitcoin-seeder
[362/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[363/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[364/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[365/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[366/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[367/482] Linking CXX static library src/wallet/libwallet.a
[368/482] Linking CXX static library src/wallet/libwallet-tool.a
[369/482] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Snippet of first build failure:

                       ChainActive
../../src/rest.cpp: At global scope:
../../src/rest.cpp:724:1: error: invalid conversion from ‘bool (*)(HTTPRequest*, const string&)’ {aka ‘bool (*)(HTTPRequest*, const std::__cxx11::basic_string<char>&)’} to ‘bool (*)(Config&, HTTPRequest*, const string&)’ {aka ‘bool (*)(Config&, HTTPRequest*, const std::__cxx11::basic_string<char>&)’} [-fpermissive]
 };
 ^
[298/434] Building CXX object src/CMakeFiles/server.dir/script/sigcache.cpp.o
[299/434] Building CXX object src/CMakeFiles/server.dir/rpc/abc.cpp.o
[300/434] Building CXX object src/CMakeFiles/server.dir/timedata.cpp.o
[301/434] Building CXX object src/CMakeFiles/server.dir/script/scriptcache.cpp.o
[302/434] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[303/434] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[304/434] Building CXX object src/CMakeFiles/server.dir/versionbits.cpp.o
[305/434] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[306/434] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[307/434] Building CXX object src/CMakeFiles/server.dir/rpc/server.cpp.o
[308/434] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[309/434] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[310/434] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[311/434] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[312/434] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[313/434] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[314/434] Building CXX object src/CMakeFiles/server.dir/dummywallet.cpp.o
[315/434] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[316/434] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[317/434] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[318/434] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[319/434] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[320/434] Linking C static library src/secp256k1/libsecp256k1.a
[321/434] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[322/434] Linking C executable src/secp256k1/ecmult-bench
[323/434] Linking CXX static library src/libcommon.a
[324/434] Linking C executable src/secp256k1/internal-bench
[325/434] Linking C executable src/secp256k1/sign-bench
[326/434] Linking CXX static library src/libscript.a
[327/434] Linking C executable src/secp256k1/verify-bench
[328/434] Linking CXX static library src/libbitcoinconsensus.a
[329/434] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[330/434] Linking CXX shared library src/libbitcoinconsensus.so.0.22.4
[331/434] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[332/434] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[333/434] Linking CXX executable src/bitcoin-cli
[334/434] Linking C executable src/secp256k1/recover-bench
[335/434] Linking CXX executable src/bitcoin-tx
[336/434] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[337/434] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[338/434] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[339/434] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[340/434] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[341/434] Linking CXX static library src/seeder/libseeder.a
[342/434] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[343/434] Building CXX object src/CMakeFiles/server.dir/ui_interface.cpp.o
[344/434] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[345/434] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[346/434] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[347/434] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[348/434] Linking CXX executable src/seeder/bitcoin-seeder
[349/434] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[350/434] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Snippet of first build failure:

[320/484] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[321/484] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[322/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[323/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[324/484] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[325/484] Linking C static library src/secp256k1/libsecp256k1.a
[326/484] Linking C executable src/secp256k1/ecmult-bench
[327/484] Linking C executable src/secp256k1/internal-bench
[328/484] Linking C executable src/secp256k1/sign-bench
[329/484] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[330/484] Linking C executable src/secp256k1/verify-bench
[331/484] Linking C executable src/secp256k1/recover-bench
[332/484] Linking CXX static library src/libscript.a
[333/484] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[334/484] Linking CXX static library src/libcommon.a
[335/484] Linking CXX static library src/libbitcoinconsensus.a
[336/484] Linking CXX shared library src/libbitcoinconsensus.so.0.22.4
[337/484] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[338/484] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[339/484] Linking CXX executable src/bitcoin-cli
[340/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[341/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[342/484] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[343/484] Linking CXX executable src/bitcoin-tx
[344/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[345/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[346/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[347/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[348/484] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[349/484] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[350/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[351/484] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[352/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/psbtwallet.cpp.o
[353/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[354/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[355/484] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[356/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[357/484] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[358/484] Linking CXX static library src/seeder/libseeder.a
[359/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[360/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[361/484] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[362/484] Linking CXX executable src/seeder/bitcoin-seeder
[363/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[364/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[365/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[366/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[367/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[368/484] Linking CXX static library src/wallet/libwallet.a
[369/484] Linking CXX static library src/wallet/libwallet-tool.a
[370/484] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Snippet of first build failure:

[312/482] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[313/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[314/482] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[315/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[316/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[317/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[318/482] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[319/482] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[320/482] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[321/482] Linking C static library src/secp256k1/libsecp256k1.a
[322/482] Linking C executable src/secp256k1/ecmult-bench
[323/482] Linking C executable src/secp256k1/internal-bench
[324/482] Linking C executable src/secp256k1/sign-bench
[325/482] Linking C executable src/secp256k1/verify-bench
[326/482] Linking C executable src/secp256k1/recover-bench
[327/482] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[328/482] Linking CXX static library src/libscript.a
[329/482] Linking CXX static library src/libcommon.a
[330/482] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[331/482] Linking CXX static library src/libbitcoinconsensus.a
[332/482] Linking CXX executable src/bitcoin-cli
[333/482] Linking CXX shared library src/libbitcoinconsensus.so.0.22.4
[334/482] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[335/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[336/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[337/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[338/482] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[339/482] Linking CXX executable src/bitcoin-tx
[340/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[341/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[342/482] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[343/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[344/482] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[345/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/psbtwallet.cpp.o
[346/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[347/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[348/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[349/482] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[350/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[351/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[352/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[353/482] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[354/482] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[355/482] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[356/482] Linking CXX static library src/seeder/libseeder.a
[357/482] Linking CXX executable src/seeder/bitcoin-seeder
[358/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[359/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[360/482] Linking CXX static library src/zmq/libzmq.a
[361/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[362/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[363/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[364/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[365/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[366/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[367/482] Linking CXX static library src/wallet/libwallet.a
[368/482] Linking CXX static library src/wallet/libwallet-tool.a
[369/482] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Snippet of first build failure:

[312/482] Linking C executable src/secp256k1/verify-bench
[313/482] Linking C executable src/secp256k1/recover-bench
[314/482] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/hash.cpp.o
[315/482] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[316/482] Building CXX object src/CMakeFiles/util.dir/rpc/request.cpp.o
[317/482] Building CXX object src/CMakeFiles/util.dir/util/error.cpp.o
[318/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[319/482] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[320/482] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[321/482] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[322/482] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[323/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[324/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[325/482] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[326/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[327/482] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[328/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[329/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[330/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[331/482] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[332/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[333/482] Linking CXX static library src/libutil.a
[334/482] Linking CXX static library src/libscript.a
[335/482] Linking CXX static library src/libcommon.a
[336/482] Linking CXX static library src/librpcclient.a
[337/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[338/482] Linking CXX executable src/bitcoin-cli
[339/482] Linking CXX static library src/libbitcoinconsensus.a
[340/482] Linking CXX shared library src/libbitcoinconsensus.so.0.22.4
[341/482] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[342/482] Linking CXX executable src/bitcoin-tx
[343/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[344/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[345/482] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[346/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[347/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[348/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[349/482] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[350/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[351/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/psbtwallet.cpp.o
[352/482] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[353/482] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[354/482] Linking CXX static library src/seeder/libseeder.a
[355/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[356/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[357/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[358/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[359/482] Linking CXX static library src/zmq/libzmq.a
[360/482] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[361/482] Linking CXX executable src/seeder/bitcoin-seeder
[362/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[363/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[364/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[365/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[366/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[367/482] Linking CXX static library src/wallet/libwallet.a
[368/482] Linking CXX static library src/wallet/libwallet-tool.a
[369/482] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

fix a style issue picked up by build-clang-tidy

This revision is now accepted and ready to land.Sep 30 2020, 14:51