Cleanup SplashScreen class
ClosedPublic
Actions

Authored by PiRK on Oct 9 2020, 08:55.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC75732ddc2236: Cleanup SplashScreen class

Summary

Cleaning up after replacing the QSplashScreen base class with the
QWidget class (PR4941).

Backport of Core PR14854

Test Plan

ninja && ninja check
src/qt/bitcoin-qt

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr14854

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13290
Build 26620: Build Diff	build-clang · build-diff · build-clang-tidy · build-without-wallet · lint-circular-dependencies
Build 26619: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 9 2020, 08:55

Owners added a reviewer: Restricted Owners Package.Oct 9 2020, 08:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2020, 08:55

PiRK requested review of this revision.Oct 9 2020, 08:55

teamcity edited the summary of this revision. (Show Details)Oct 9 2020, 08:55

Harbormaster completed remote builds in B13290: Diff 24436.Oct 9 2020, 09:05

Fabien accepted this revision.Oct 9 2020, 09:59

This revision is now accepted and ready to land.Oct 9 2020, 09:59

Closed by commit rABC75732ddc2236: Cleanup SplashScreen class (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyOct 9 2020, 11:23

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC75732ddc2236: Cleanup SplashScreen class.

Revision Contents
Changeset List

Path

Size

src/

qt/

2 lines

8 lines

8 lines

4 lines

Diff 24436

View Options

src/qt/bitcoin.h

View Options

src/qt/bitcoin.cpp

View Options

src/qt/splashscreen.h

View Options

Cleanup SplashScreen classClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24436

src/qt/bitcoin.h

src/qt/bitcoin.cpp

src/qt/splashscreen.h

src/qt/splashscreen.cpp

Cleanup SplashScreen class
ClosedPublic
Actions

Revision Contents
Changeset List