Differential D7897

[cleanup] Remove ranged for loops over OUTPUT_TYPES from PR17261
AbandonedPublic
Actions

Authored by majcosta on Oct 12 2020, 20:44.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Summary

The above mentioned backport (D7849) has a few interations over output types
which we do not have. This removes them.

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cleanup_output_types

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13372
Build 26782: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang · build-clang-tidy
Build 26781: arc lint + arc unit

Event Timeline

majcosta created this revision.Oct 12 2020, 20:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2020, 20:44

majcosta requested review of this revision.Oct 12 2020, 20:44

Harbormaster completed remote builds in B13370: Diff 24577.Oct 12 2020, 20:56

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[0m[0;32mrpc_getblockstats.py                             | ✓ Passed  | 1 s
[0m[0;32mrpc_getchaintips.py                              | ✓ Passed  | 3 s
[0m[0;32mrpc_help.py                                      | ✓ Passed  | 1 s
[0m[0;32mrpc_invalidateblock.py                           | ✓ Passed  | 6 s
[0m[0;32mrpc_misc.py                                      | ✓ Passed  | 1 s
[0m[0;32mrpc_named_arguments.py                           | ✓ Passed  | 1 s
[0m[0;32mrpc_net.py                                       | ✓ Passed  | 1 s
[0m[0;32mrpc_preciousblock.py                             | ✓ Passed  | 1 s
[0m[0;32mrpc_psbt.py                                      | ✓ Passed  | 34 s
[0m[0;32mrpc_rawtransaction.py                            | ✓ Passed  | 42 s
[0m[0;32mrpc_scantxoutset.py                              | ✓ Passed  | 4 s
[0m[0;32mrpc_setban.py                                    | ✓ Passed  | 2 s
[0m[0;32mrpc_signmessage.py                               | ✓ Passed  | 1 s
[0m[0;32mrpc_signrawtransaction.py                        | ✓ Passed  | 1 s
[0m[0;32mrpc_txoutproof.py                                | ✓ Passed  | 2 s
[0m[0;32mrpc_uptime.py                                    | ✓ Passed  | 1 s
[0m[0;32mrpc_users.py                                     | ✓ Passed  | 4 s
[0m[0;32mrpc_whitelist.py                                 | ✓ Passed  | 1 s
[0m[0;32mtool_wallet.py                                   | ✓ Passed  | 3 s
[0m[0;32mwallet_abandonconflict.py                        | ✓ Passed  | 6 s
[0m[0;32mwallet_address_types.py                          | ✓ Passed  | 16 s
[0m[0;32mwallet_avoidreuse.py                             | ✓ Passed  | 6 s
[0m[0;32mwallet_balance.py                                | ✓ Passed  | 45 s
[0m[0;32mwallet_basic.py                                  | ✓ Passed  | 32 s
[0m[0;32mwallet_coinbase_category.py                      | ✓ Passed  | 1 s
[0m[0;32mwallet_create_tx.py                              | ✓ Passed  | 7 s
[0m[0;32mwallet_createwallet.py                           | ✓ Passed  | 2 s
[0m[0;32mwallet_createwallet.py --usecli                  | ✓ Passed  | 3 s
[0m[0;32mwallet_disable.py                                | ✓ Passed  | 1 s
[0m[0;32mwallet_dump.py                                   | ✓ Passed  | 3 s
[0m[0;32mwallet_encryption.py                             | ✓ Passed  | 5 s
[0m[0;32mwallet_groups.py                                 | ✓ Passed  | 51 s
[0m[0;32mwallet_hd.py                                     | ✓ Passed  | 7 s
[0m[0;32mwallet_import_rescan.py                          | ✓ Passed  | 6 s
[0m[0;32mwallet_import_with_label.py                      | ✓ Passed  | 1 s
[0m[0;32mwallet_importmulti.py                            | ✓ Passed  | 3 s
[0m[0;32mwallet_importprunedfunds.py                      | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool.py                                | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                          | ✓ Passed  | 2 s
[0m[0;32mwallet_labels.py                                 | ✓ Passed  | 1 s
[0m[0;32mwallet_listreceivedby.py                         | ✓ Passed  | 12 s
[0m[0;32mwallet_listsinceblock.py                         | ✓ Passed  | 4 s
[0m[0;32mwallet_listtransactions.py                       | ✓ Passed  | 8 s
[0m[0;32mwallet_multiwallet.py                            | ✓ Passed  | 15 s
[0m[0;32mwallet_multiwallet.py --usecli                   | ✓ Passed  | 17 s
[0m[0;32mwallet_reorgsrestore.py                          | ✓ Passed  | 3 s
[0m[0;32mwallet_resendwallettransactions.py               | ✓ Passed  | 5 s
[0m[0;32mwallet_txn_clone.py                              | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py --mineblock                  | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py                        | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_doublespend.py --mineblock            | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py                              | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli                     | ✓ Passed  | 1 s
[0m[0;32mwallet_zapwallettxes.py                          | ✓ Passed  | 4 s
[0m[1m
ALL                                              | ✓ Passed  | 896 s (accumulated) 
[0mRuntime: 180 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_bind.py

majcosta edited the summary of this revision. (Show Details)Oct 12 2020, 21:16

rebase

Harbormaster completed remote builds in B13372: Diff 24580.Oct 12 2020, 23:28

While OUTPUT_TYPES is not itself useful, this patch is only going to induce merge conflicts. This trade-off does not seem worth it since it does not get rid of a substantial amount of code.

This revision now requires changes to proceed.Oct 12 2020, 23:47

alright