Differential D7912

Merge #16470: test: Fail early on disconnect in mininode.wait_for_*
ClosedPublic
Actions

Authored by jasonbcox on Oct 13 2020, 23:22.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC8fc318140dfd: Merge #16470: test: Fail early on disconnect in mininode.wait_for_*

Summary

fac2e6a6045e4ddd6b473f4f3ddbb69d9d6921f6 test: Fail early on disconnect in mininode.wait_for_* (MarcoFalke)

Pull request description:

The node might crash or disconnect when our mininode waits for data. Due to the crash, the data is guaranteed to never arrive and we can fail early with an assert

Backport of Core PR16470

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16470

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13389
Build 26814: Build Diff	build-diff · lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-clang
Build 26813: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 13 2020, 23:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 13 2020, 23:22

jasonbcox requested review of this revision.Oct 13 2020, 23:22

teamcity edited the summary of this revision. (Show Details)Oct 13 2020, 23:23

jasonbcox added inline comments.Oct 13 2020, 23:24

test/functional/test_framework/mininode.py
537	The left side does not match the original PR because we diverged here a long time ago. I opted to bring us more inline with Core's code even though ours reads slightly better.