Page MenuHomePhabricator

[BUILDBOT] Use tokens as an immediate feedback and anti DoS mechanism
ClosedPublic

Authored by Fabien on Oct 23 2020, 14:59.

Details

Summary

Tokens are awarded on a per-user and per-object basis, and are
persistent, which make them a good candidate for an anti-DoS as the bot
can find the previous state and decide based on this.
The current filter allow any approved, verified, and activated non ABC
user to request builds from the bot, with a total limit of 4 requests
per revision. ABC members bypass this rule.

This token mechanism also provide a discrete immediate positive feedback
to the user, improving the UX.

Depends on D8086.

Test Plan
pytest

Diff Detail

Repository
rABC Bitcoin ABC
Branch
buildbot_triggerci_permissions
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13638
Build 27305: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 27304: arc lint + arc unit