Page MenuHomePhabricator
Differential D8133

[backport#12510] test: Add rpc_bind test to default-run tests
ClosedPublic
Actions

Authored by majcosta on Oct 26 2020, 20:27.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC3a91cc08c7a8: [backport#12510] test: Add rpc_bind test to default-run tests
Summary

e87fefc test: Add rpc_bind test to default-run tests (Wladimir J. van der Laan)

Pull request description:

Skip the parts that cannot be run on the host due to lack of IPv6 support or a second interface to bind on, and warn appropriately.

Without no strong requirements (besides being Linux only, which will skip the test) left, add this test to the default in test_runner.

~~(the non-IPv6 parts of the two dual-IPv4/6 tests could also be enabled, but first going to look what Travis does here to see if there wasn't another reason it was disabled)~~ done, it only makes sense for the first

Backport of Core PR12510

Test Plan
ninja all
test-runner.py rpc_bind

Diff Detail

Event Timeline

majcosta created this revision.Oct 26 2020, 20:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 26 2020, 20:27
majcosta requested review of this revision.Oct 26 2020, 20:27
teamcity edited the summary of this revision. (Show Details)Oct 26 2020, 20:27
majcosta added a child revision: D8134: [backport#14790] Tests: Allow running rpc_bind.py --nonloopback test without IPv6.Oct 26 2020, 20:38
Harbormaster completed remote builds in B13689: Diff 25127.Oct 26 2020, 20:38
jasonbcox requested changes to this revision.Oct 26 2020, 20:46
jasonbcox added a subscriber: jasonbcox.

Missing the equivalent change to test_runner's TEST_PARAMS

This revision now requires changes to proceed.Oct 26 2020, 20:46
majcosta updated this revision to Diff 25134.Oct 26 2020, 21:48

added all missing CLI options to the runner

jasonbcox accepted this revision.Oct 26 2020, 21:59
This revision is now accepted and ready to land.Oct 26 2020, 21:59
Harbormaster completed remote builds in B13692: Diff 25134.Oct 26 2020, 22:00
Closed by commit rABC3a91cc08c7a8: [backport#12510] test: Add rpc_bind test to default-run tests (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyOct 26 2020, 22:30
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC3a91cc08c7a8: [backport#12510] test: Add rpc_bind test to default-run tests.

Revision Contents
Changeset List

PathSize
test/
functional/
139 lines
1 line

Diff 25134

View Options

test/functional/rpc_bind.py

Loading...
View Options

test/functional/test_runner.py

Loading...