Differential D8231

bench: Fix negative values and zero for -evals flag
ClosedPublic
Actions

Authored by PiRK on Nov 2 2020, 09:15.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC8dab59074ce6: bench: Fix negative values and zero for -evals flag

Summary

This is a backport of Core PR17267

Test Plan

$ ninja
$ src/bench/bitcoin-bench -evals -2
Error parsing command line arguments: Invalid parameter -2
$ echo $?
1
$ src/bench/bitcoin-bench -evals=0
$ echo $?
0

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr17267

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13811
Build 27641: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang · build-clang-tidy · build-debug · build-diff
Build 27640: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 2 2020, 09:15

Owners added a reviewer: Restricted Owners Package.Nov 2 2020, 09:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2020, 09:15

PiRK requested review of this revision.Nov 2 2020, 09:15

teamcity edited the summary of this revision. (Show Details)Nov 2 2020, 09:15

Harbormaster completed remote builds in B13811: Diff 25344.Nov 2 2020, 09:25

majcosta accepted this revision.Nov 2 2020, 16:12

This revision is now accepted and ready to land.Nov 2 2020, 16:12

Closed by commit rABC8dab59074ce6: bench: Fix negative values and zero for -evals flag (authored by nijynot <nijynot@gmail.com>, committed by PiRK). · Explain WhyNov 2 2020, 17:01

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC8dab59074ce6: bench: Fix negative values and zero for -evals flag.

Revision Contents
Changeset List

Path

Size

src/

bench/

bench_bitcoin.cpp

8 lines

Diff 25344

src/bench/bench_bitcoin.cpp

Loading...