Add assertion to randrange that input is not 0
ClosedPublic
Actions

Authored by PiRK on Nov 2 2020, 13:51.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC7d825c51c440: Add assertion to randrange that input is not 0

Summary

randrange is not intended to be called with argument 0.

This is a backport of Core PR17293

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr17293

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13817
Build 27653: Build Diff	build-without-wallet · lint-circular-dependencies · build-debug · build-clang · build-clang-tidy · build-diff
Build 27652: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 2 2020, 13:51

Owners added a reviewer: Restricted Owners Package.Nov 2 2020, 13:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2020, 13:51

PiRK requested review of this revision.Nov 2 2020, 13:51

teamcity edited the summary of this revision. (Show Details)Nov 2 2020, 13:52

Harbormaster completed remote builds in B13817: Diff 25350.Nov 2 2020, 14:02

jasonbcox accepted this revision.Nov 2 2020, 17:19

This revision is now accepted and ready to land.Nov 2 2020, 17:19

Closed by commit rABC7d825c51c440: Add assertion to randrange that input is not 0 (authored by Jeremy Rubin <j@rubin.io>, committed by PiRK). · Explain WhyNov 2 2020, 19:39

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7d825c51c440: Add assertion to randrange that input is not 0.

Revision Contents
Changeset List

Path

Size

src/

random.h

1 line

Diff 25350

View Options

Add assertion to randrange that input is not 0ClosedPublicActions