Split fixed seeds to support multiple networks
AcceptedPublic
Actions

Authored by jasonbcox on Nov 9 2020, 22:37.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

See title.

Depends on D8339

Test Plan

ninja check
python3 generate-seeds.py abc > ../../src/networks/abc/chainparamsseeds.cpp
python3 generate-seeds.py bchn > ../../src/networks/bchn/chainparamsseeds.cpp

generate-seeds.py output should match the current patch, so no uncommitted changes
should be present.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

multichain-seeds

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13952
Build 27912: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 27911: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 9 2020, 22:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2020, 22:37

jasonbcox requested review of this revision.Nov 9 2020, 22:37

Rebase

Harbormaster completed remote builds in B13950: Diff 25599.Nov 9 2020, 22:56

Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "chainparams -> chainparamsseeds -> chainparams" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1

Harbormaster completed remote builds in B13952: Diff 25601.Nov 9 2020, 23:27

Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "chainparams -> chainparamsseeds -> chainparams" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1

jasonbcox planned changes to this revision.Nov 9 2020, 23:49

Move SeedSpec6 to more appropriate header file to fix circular dependency

jasonbcox added a child revision: D8341: Make seed updating automation support multiple networks.Nov 10 2020, 00:03

Harbormaster completed remote builds in B13953: Diff 25602.Nov 10 2020, 00:18

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[0m[0;32mwallet_create_tx.py                              | ✓ Passed  | 10 s
[0m[0;32mwallet_createwallet.py                           | ✓ Passed  | 2 s
[0m[0;32mwallet_createwallet.py --usecli                  | ✓ Passed  | 3 s
[0m[0;32mwallet_disable.py                                | ✓ Passed  | 1 s
[0m[0;32mwallet_dump.py                                   | ✓ Passed  | 3 s
[0m[0;32mwallet_encryption.py                             | ✓ Passed  | 6 s
[0m[0;32mwallet_groups.py                                 | ✓ Passed  | 54 s
[0m[0;32mwallet_hd.py                                     | ✓ Passed  | 6 s
[0m[0;32mwallet_import_rescan.py                          | ✓ Passed  | 8 s
[0m[0;32mwallet_import_with_label.py                      | ✓ Passed  | 1 s
[0m[0;32mwallet_importmulti.py                            | ✓ Passed  | 4 s
[0m[0;32mwallet_importprunedfunds.py                      | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool.py                                | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                          | ✓ Passed  | 3 s
[0m[0;32mwallet_labels.py                                 | ✓ Passed  | 2 s
[0m[0;32mwallet_listreceivedby.py                         | ✓ Passed  | 16 s
[0m[0;32mwallet_listsinceblock.py                         | ✓ Passed  | 5 s
[0m[0;32mwallet_listtransactions.py                       | ✓ Passed  | 7 s
[0m[0;32mwallet_multiwallet.py                            | ✓ Passed  | 12 s
[0m[0;32mwallet_reorgsrestore.py                          | ✓ Passed  | 3 s
[0m[0;32mwallet_resendwallettransactions.py               | ✓ Passed  | 5 s
[0m[0;32mwallet_txn_clone.py                              | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py --mineblock                  | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py                        | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py --mineblock            | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py                              | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli                     | ✓ Passed  | 1 s
[0m[0;32mwallet_zapwallettxes.py                          | ✓ Passed  | 5 s
[0m[1m
ALL                                              | ✓ Passed  | 961 s (accumulated) 
[0mRuntime: 193 s

[22/423] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
[23/423] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[157/423] avalanche: testing peermanager_tests
FAILED: src/avalanche/test/CMakeFiles/check-avalanche-peermanager_tests 
cd /work/abc-ci-builds/build-debug/src/avalanche/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/avalanche-peermanager_tests.log /work/abc-ci-builds/build-debug/src/avalanche/test/test-avalanche --run_test=peermanager_tests --logger=HRF,test_suite:JUNIT,message,avalanche-peermanager_tests.xml --catch_system_errors=no
Running 7 test cases...
Entering test module "Avalanche Test Suite"
../../src/avalanche/test/peermanager_tests.cpp(15): Entering test suite "peermanager_tests"
../../src/avalanche/test/peermanager_tests.cpp(17): Entering test case "select_peer_linear"
../../src/avalanche/test/peermanager_tests.cpp(17): Leaving test case "select_peer_linear"; testing time: 75124us
../../src/avalanche/test/peermanager_tests.cpp(69): Entering test case "select_peer_dichotomic"
../../src/avalanche/test/peermanager_tests.cpp(69): Leaving test case "select_peer_dichotomic"; testing time: 22735us
../../src/avalanche/test/peermanager_tests.cpp(124): Entering test case "select_peer_random"
test-avalanche: ../../src/./random.h:184: uint64_t FastRandomContext::randrange(uint64_t): Assertion `range' failed.
Aborted (core dumped)
[169/423] secp256k1: testing secp256k1-tests
ninja: build stopped: subcommand failed.
Build build-debug failed with exit code 1

Note: the test failure is fixed in D8345

jasonbcox planned changes to this revision.Nov 10 2020, 20:11

Rebase. Note that D8339 has taken on some of the changes that were in this
patch as they belong there instead.

Harbormaster completed remote builds in B14004: Diff 25687.Nov 12 2020, 17:03

Fabien accepted this revision.Nov 13 2020, 07:06

This revision is now accepted and ready to land.Nov 13 2020, 07:06