Page MenuHomePhabricator
Differential D8345

Fix a rare failure in the peermanager tests
ClosedPublic
Actions

Authored by Fabien on Nov 10 2020, 08:21.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCb8f762ba7906: Fix a rare failure in the peermanager tests
Summary

The randrange() method expects the range to be non zero.
In the peermanager_tests/select_peer_random case the max variable
can be 0 and fail the test. Since we still want to test slot 0, set slot = 0
when max == 0 without calling the randrange() method.

Test Plan
ninja check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_peermanager_tests_randrange
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13958
Build 27924: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 27923: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 10 2020, 08:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2020, 08:21
Fabien requested review of this revision.Nov 10 2020, 08:21
Harbormaster completed remote builds in B13958: Diff 25609.Nov 10 2020, 08:31
PiRK edited the summary of this revision. (Show Details)Nov 10 2020, 08:43
PiRK accepted this revision.Nov 10 2020, 08:45
PiRK added a subscriber: PiRK.

I updated the revision so that the last line does not start with a = because it was parsed as a very large title.

This revision is now accepted and ready to land.Nov 10 2020, 08:45
Fabien mentioned this in D8340: Split fixed seeds to support multiple networks.Nov 10 2020, 08:59
Fabien added a comment.Nov 10 2020, 09:32

@PiRK Thanks

Closed by commit rABCb8f762ba7906: Fix a rare failure in the peermanager tests (authored by Fabien). · Explain WhyNov 10 2020, 09:33
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCb8f762ba7906: Fix a rare failure in the peermanager tests.

Revision Contents
Changeset List

PathSize
src/
avalanche/
test/
2 lines

Diff 25609

View Options

src/avalanche/test/peermanager_tests.cpp

Loading...