Paths

Table of Contentst

Differential D8363

gui: Drop unused return values in WalletFrame
ClosedPublic
Actions

Authored by PiRK on Nov 11 2020, 06:45.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCe6ac31ddc732: gui: Drop unused return values in WalletFrame

Summary

This is a backport of Core PR15464

addWallet is not modified because the return value is added back and used in PR16963 which was backported in D7699.

Test Plan

ninja && src/qt/bitcoin-qt

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr15464

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13979
Build 27965: Build Diff	lint-circular-dependencies · build-clang-tidy · build-without-wallet · build-debug · build-clang · build-diff
Build 27964: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 11 2020, 06:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2020, 06:45

PiRK requested review of this revision.Nov 11 2020, 06:45

teamcity edited the summary of this revision. (Show Details)Nov 11 2020, 06:45

Harbormaster completed remote builds in B13979: Diff 25648.Nov 11 2020, 06:53

majcosta accepted this revision.Nov 11 2020, 17:05

This revision is now accepted and ready to land.Nov 11 2020, 17:05

Closed by commit rABCe6ac31ddc732: gui: Drop unused return values in WalletFrame (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyNov 11 2020, 19:21

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe6ac31ddc732: gui: Drop unused return values in WalletFrame.

Revision Contents
Changeset List

Path

Size

src/

qt/

walletframe.h

4 lines

walletframe.cpp

10 lines

Diff 25648

View Options

src/qt/walletframe.h