Differential D8402

Return nullptr from GetLegacyScriptPubKeyMan if descriptor wallet
ClosedPublic
Actions

Authored by deadalnix on Nov 14 2020, 18:06.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCe9201a674f1e: Return nullptr from GetLegacyScriptPubKeyMan if descriptor wallet

Summary

Backport of Core PR16528 part [4/43] : https://github.com/bitcoin/bitcoin/pull/16528/commits/aeac157c9dc141546b45e06ba9c2e641ad86083f

Depends on D8401

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16528-4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14036
Build 28078: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang · build-debug · build-clang-tidy
Build 28077: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 14 2020, 18:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 14 2020, 18:06

deadalnix requested review of this revision.Nov 14 2020, 18:06

teamcity edited the summary of this revision. (Show Details)Nov 14 2020, 18:06

Harbormaster completed remote builds in B14036: Diff 25745.Nov 14 2020, 18:18

majcosta accepted this revision.Nov 14 2020, 20:44

This revision is now accepted and ready to land.Nov 14 2020, 20:44

Closed by commit rABCe9201a674f1e: Return nullptr from GetLegacyScriptPubKeyMan if descriptor wallet (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyNov 14 2020, 20:57

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCe9201a674f1e: Return nullptr from GetLegacyScriptPubKeyMan if descriptor wallet.

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

5 lines

Diff 25745

View Options

Return nullptr from GetLegacyScriptPubKeyMan if descriptor walletClosedPublicActions