Differential D8455

Be able to create new wallets with DescriptorScriptPubKeyMans as backing
ClosedPublic
Actions

Authored by deadalnix on Nov 19 2020, 00:21.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2ab0aaff663c: Be able to create new wallets with DescriptorScriptPubKeyMans as backing

Summary

Backport of Core PR16528 [33/43] : https://github.com/bitcoin/bitcoin/pull/16528/commits/82ae02b1656819f4bd5023b8955447e1d4ea8692

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16528-33

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14099
Build 28200: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-diff · build-clang · build-debug
Build 28199: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 19 2020, 00:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2020, 00:21

deadalnix requested review of this revision.Nov 19 2020, 00:21

teamcity edited the summary of this revision. (Show Details)Nov 19 2020, 00:21

Harbormaster completed remote builds in B14099: Diff 25856.Nov 19 2020, 00:27

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: p2p_timeouts.py ======

------- Stdout: -------
2020-11-19T00:25:37.955000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201119_002505/p2p_timeouts_581
2020-11-19T00:25:43.271000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 120, in main
    self.run_test()
  File "/work/test/functional/p2p_timeouts.py", line 89, in run_test
    assert not no_verack_node.is_connected
AssertionError
2020-11-19T00:25:43.973000Z TestFramework (INFO): Stopping nodes
2020-11-19T00:25:44.825000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201119_002505/p2p_timeouts_581
2020-11-19T00:25:44.825000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201119_002505/p2p_timeouts_581/test_framework.log
2020-11-19T00:25:44.826000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201119_002505/p2p_timeouts_581' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests: p2p_timeouts.py

deadalnix added a child revision: D8457: Generate new descriptors when encrypting.Nov 19 2020, 00:39

Fabien accepted this revision.Nov 19 2020, 08:38

This revision is now accepted and ready to land.Nov 19 2020, 08:38

This revision was landed with ongoing or failed builds.Nov 19 2020, 13:46

Closed by commit rABC2ab0aaff663c: Be able to create new wallets with DescriptorScriptPubKeyMans as backing (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain Why

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC2ab0aaff663c: Be able to create new wallets with DescriptorScriptPubKeyMans as backing.