Differential D8614

walletdb: moveonly: Move BerkeleyBatch Cursor and Txn funcs to cpp
ClosedPublic
Actions

Authored by Fabien on Dec 7 2020, 10:50.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC7fc87af9221d: walletdb: moveonly: Move BerkeleyBatch Cursor and Txn funcs to cpp

Summary

Put the implementation in the cpp, not the h file.

Partial backport (4/5) of core PR19290:
https://github.com/bitcoin/bitcoin/pull/19290/commits/8f033642a8c6874184e297b97b951b9bd12ffd75

Depends on D8613.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19290_p4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14327
Build 28629: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28628: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 7 2020, 10:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2020, 10:50

Fabien requested review of this revision.Dec 7 2020, 10:50

teamcity edited the summary of this revision. (Show Details)Dec 7 2020, 10:50

Fabien added a child revision: D8615: walletdb: Move BDB specific things into bdb.{cpp/h}.Dec 7 2020, 10:53

Harbormaster completed remote builds in B14327: Diff 26228.Dec 7 2020, 11:13

deadalnix accepted this revision.Dec 7 2020, 13:15

This revision is now accepted and ready to land.Dec 7 2020, 13:15

Closed by commit rABC7fc87af9221d: walletdb: moveonly: Move BerkeleyBatch Cursor and Txn funcs to cpp (authored by Andrew Chow <achow101-github@achow101.com>, committed by Fabien). · Explain WhyDec 7 2020, 15:30

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7fc87af9221d: walletdb: moveonly: Move BerkeleyBatch Cursor and Txn funcs to cpp.

Revision Contents
Changeset List

Path

Size

src/

wallet/

db.h

68 lines

db.cpp

64 lines

Diff 26228

View Options

src/wallet/db.h