Differential D8616

wallet: Remove boost from PeriodicFlush
ClosedPublic
Actions

Authored by Fabien on Dec 7 2020, 12:58.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC4a00dfee75c0: wallet: Remove boost from PeriodicFlush

Summary

The boost::this_thread::interruption_point() in the code base currently
block the replacement of boost::thread with std::thread. [1]

Remove them from the wallet because they are either unused or useless.

Backport of core PR18792.

Depends on D8615.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR18792

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14331
Build 28637: Build Diff	lint-circular-dependencies · build-without-wallet · build-debug · build-clang · build-diff · build-clang-tidy
Build 28636: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 7 2020, 12:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2020, 12:58

Fabien requested review of this revision.Dec 7 2020, 12:58

teamcity edited the summary of this revision. (Show Details)Dec 7 2020, 12:58

Harbormaster completed remote builds in B14331: Diff 26232.Dec 7 2020, 13:11

Fabien added a child revision: D8617: wallet: Move BerkeleyBatch static functions to BerkeleyDatabase.Dec 7 2020, 13:24

majcosta accepted this revision.Dec 7 2020, 13:46

This revision is now accepted and ready to land.Dec 7 2020, 13:46

Closed by commit rABC4a00dfee75c0: wallet: Remove boost from PeriodicFlush (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyDec 7 2020, 15:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4a00dfee75c0: wallet: Remove boost from PeriodicFlush.

Revision Contents
Changeset List

Path

Size

src/

wallet/

3 lines

4 lines

Diff 26232

src/wallet/bdb.cpp

Loading...

src/wallet/walletdb.cpp

Loading...