Differential D8747

[backport#17085] init: Change fallback locale to C.UTF-8
ClosedPublic
Actions

Authored by majcosta on Dec 24 2020, 02:59.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCd7795abdf91b: [backport#17085] init: Change fallback locale to C.UTF-8

Summary

facb9a1315f97489a20eb0e969fdb14b5128ed2f init: Change fallback locale to C.UTF-8 (Wladimir J. van der Laan)

Pull request description:

Much of our code assumes file system UTF-8 support, and this is a more realistic guess for modern systems anyway than the default character set (which would be ASCII only). So change the assumed fallback locale (if no locale is defined by the user or OS) to `C.UTF-8`.

related: https://github.com/bitcoin/bitcoin/issues/14948#issuecomment-488385462

Backport of Core PR17085

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Dec 24 2020, 02:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 24 2020, 02:59

majcosta requested review of this revision.Dec 24 2020, 02:59

teamcity edited the summary of this revision. (Show Details)Dec 24 2020, 02:59

Harbormaster completed remote builds in B14514: Diff 26547.Dec 24 2020, 03:13

PiRK accepted this revision.Dec 24 2020, 13:46

This revision is now accepted and ready to land.Dec 24 2020, 13:46

Closed by commit rABCd7795abdf91b: [backport#17085] init: Change fallback locale to C.UTF-8 (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhyDec 24 2020, 15:59

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCd7795abdf91b: [backport#17085] init: Change fallback locale to C.UTF-8.

Revision Contents
Changeset List

Path

Size

src/

util/

4 lines

Diff 26559

src/util/system.cpp

Loading...