Differential D8884

rpc: fix broken RPCExamples for waitforblock(height)
ClosedPublic
Actions

Authored by PiRK on Jan 12 2021, 16:09.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC466d6dbef804: rpc: fix broken RPCExamples for waitforblock(height)

Summary

Fixes the following RPCExamples:
-> ExampleCli waitforblock (removed comma between arguments)
-> ExampleCli waitforblockheight (removed comma between arguments)
-> ExampleRpc waitforblockheight (removed quotation marks around integer argument)

This is a backport of Core PR18398

Test Plan

ninja && src/bitcoind &
sleep 5
src/bitcoin-cli waitforblockheight 100 1000
src/bitcoin-cli waitforblock  "0000000000079f8ef3d2c688c244eb7a4570b24c9ed7b4a8c619eb02596f8862" 1000

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 12 2021, 16:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 12 2021, 16:09

PiRK requested review of this revision.Jan 12 2021, 16:09

teamcity edited the summary of this revision. (Show Details)Jan 12 2021, 16:09

Harbormaster completed remote builds in B14721: Diff 26885.Jan 12 2021, 16:44

majcosta accepted this revision.Jan 12 2021, 18:31

This revision is now accepted and ready to land.Jan 12 2021, 18:31

Closed by commit rABC466d6dbef804: rpc: fix broken RPCExamples for waitforblock(height) (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyJan 13 2021, 07:48

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC466d6dbef804: rpc: fix broken RPCExamples for waitforblock(height).

Revision Contents
Changeset List

Path

Size

src/

rpc/

6 lines

Diff 26894

src/rpc/blockchain.cpp

Loading...