Paths

Table of Contentst

Differential D8932

test: Verify findCommonAncestor always initializes outputs
ClosedPublic
Actions

Authored by PiRK on Jan 15 2021, 15:17.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC7d707861f71c: test: Verify findCommonAncestor always initializes outputs

Summary

Also add code comment to clarify surprising code noted by practicalswift
https://github.com/bitcoin/bitcoin/pull/18657#issuecomment-614278450

See also discussion on unmerged PR18657, for why this test is added.

This is a backport of Core PR18660

Test Plan

ninja && ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 15 2021, 15:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2021, 15:17

PiRK requested review of this revision.Jan 15 2021, 15:17

teamcity edited the summary of this revision. (Show Details)Jan 15 2021, 15:17

Harbormaster completed remote builds in B14804: Diff 27014.Jan 15 2021, 15:30

majcosta accepted this revision.Jan 15 2021, 15:35

This revision is now accepted and ready to land.Jan 15 2021, 15:35

Closed by commit rABC7d707861f71c: test: Verify findCommonAncestor always initializes outputs (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhyJan 15 2021, 17:38

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7d707861f71c: test: Verify findCommonAncestor always initializes outputs.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

chain.cpp

2 lines

test/

interfaces_tests.cpp

10 lines

Diff 27018

View Options

src/interfaces/chain.cpp