Differential D8969

tests: Don't assume presence of __builtin_mul_overflow in MultiplicationOverflow(...) fuzzing harness
ClosedPublic
Actions

Authored by Fabien on Jan 19 2021, 20:47.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC2fb7c38be9ca: tests: Don't assume presence of __builtin_mul_overflow in…

Summary

Backport of core PR18393.

Depends on D8967.

Test Plan

I cannot reproduce the issue myself, but I can check it doesn't break
the fuzzer:

ninja bitcoin-fuzzers
./test/fuzz/test_runner.py <path_to_corpus> multiplication_overflow

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR18393

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14853
Build 29660: Build Diff	lint-circular-dependencies · build-without-wallet · build-fuzzer · build-diff · build-debug · build-clang-tidy · build-clang
Build 29659: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 19 2021, 20:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2021, 20:47

Fabien requested review of this revision.Jan 19 2021, 20:47

teamcity edited the summary of this revision. (Show Details)Jan 19 2021, 20:47

Harbormaster completed remote builds in B14853: Diff 27093.Jan 19 2021, 21:02

PiRK accepted this revision.Jan 20 2021, 02:06

This revision is now accepted and ready to land.Jan 20 2021, 02:06

Closed by commit rABC2fb7c38be9ca: tests: Don't assume presence of __builtin_mul_overflow in… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyJan 20 2021, 08:21

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2fb7c38be9ca: tests: Don't assume presence of __builtin_mul_overflow in….

Revision Contents
Changeset List

Path

Size

src/

test/

fuzz/

multiplication_overflow.cpp

15 lines

Diff 27093

View Options

src/test/fuzz/multiplication_overflow.cpp

tests: Don't assume presence of __builtin_mul_overflow in MultiplicationOverflow(...) fuzzing harnessClosedPublicActions