Differential D8993

[backport#18669] log: Use Join() helper when listing log categories
ClosedPublic
Actions

Authored by majcosta on Jan 20 2021, 19:23.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCf9ec355922bb: [backport#18669] log: Use Join() helper when listing log categories

Summary

faec0638872798b58b9882ee079014555bc8393e log: Use Join() helper when listing log categories (MarcoFalke)

Pull request description:

This removes the global `ListLogCategories` and replaces it with a one-line member function `LogCategoriesString`, which just calls `Join`.

Should be a straightforward refactor to get rid of a few LOC.

Backport of Core PR18669

Test Plan

ninja all check check-functional
./src/bitcoin-cli logging
./src/bitcoin-cli help logging

check output's alright

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jan 20 2021, 19:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2021, 19:23

majcosta requested review of this revision.Jan 20 2021, 19:23

teamcity edited the summary of this revision. (Show Details)Jan 20 2021, 19:23

Harbormaster completed remote builds in B14885: Diff 27147.Jan 20 2021, 19:36

PiRK accepted this revision.Jan 21 2021, 07:38

This revision is now accepted and ready to land.Jan 21 2021, 07:38

Closed by commit rABCf9ec355922bb: [backport#18669] log: Use Join() helper when listing log categories (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJan 21 2021, 12:29

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCf9ec355922bb: [backport#18669] log: Use Join() helper when listing log categories.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

5 lines

logging.h

17 lines

logging.cpp

25 lines

rpc/

misc.cpp

5 lines

Diff 27180

View Options

src/init.cpp

View Options

src/logging.h

View Options

src/logging.cpp

View Options

[backport#18669] log: Use Join() helper when listing log categoriesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27180

src/init.cpp

src/logging.h

src/logging.cpp

src/rpc/misc.cpp

[backport#18669] log: Use Join() helper when listing log categories
ClosedPublic
Actions

Revision Contents
Changeset List