Get rid of unneeded CWalletTx::Init parameter
ClosedPublic
Actions

Authored by PiRK on Jan 27 2021, 10:08.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC2e0a03b7372a: Get rid of unneeded CWalletTx::Init parameter

Summary

This is a backport of Core PR9381 [2/5]
https://github.com/bitcoin/bitcoin/pull/9381/commits/bd2fbc7cdbec46400341209f4cb7e69e5b2cee19
Depends on D9074

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15007
Build 29965: Build Diff	lint-circular-dependencies · build-without-wallet · build-debug · build-diff · build-clang-tidy · build-clang
Build 29964: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 27 2021, 10:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2021, 10:08

PiRK requested review of this revision.Jan 27 2021, 10:08

teamcity edited the summary of this revision. (Show Details)Jan 27 2021, 10:09

PiRK added a child revision: D9076: Avoid copying CWalletTx in LoadToWallet.Jan 27 2021, 10:15

PiRK edited the summary of this revision. (Show Details)Jan 27 2021, 10:18

PiRK added a parent revision: D9074: Remove CWalletTx merging logic from AddToWallet.

Harbormaster completed remote builds in B15007: Diff 27351.Jan 27 2021, 10:27

majcosta accepted this revision.Jan 27 2021, 14:57

This revision is now accepted and ready to land.Jan 27 2021, 14:57

Closed by commit rABC2e0a03b7372a: Get rid of unneeded CWalletTx::Init parameter (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhyJan 27 2021, 15:54

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2e0a03b7372a: Get rid of unneeded CWalletTx::Init parameter.

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

11 lines

Diff 27351

View Options

Get rid of unneeded CWalletTx::Init parameterClosedPublicActions