Page MenuHomePhabricator

refactor: Replace RecursiveMutex with Mutex in netbase.cpp
ClosedPublic

Authored by PiRK on Mar 9 2021, 14:01.

Details

Summary

The functions that could lock this mutex, i.e., {S,G}etProxy(), {S,G}etNameProxy(), HaveNameProxy(), IsProxy(), do not call itself recursively, and do not call each other either directly or indirectly. Therefore, the g_proxyinfo_mutex could be a non-recursive mutex.

This is a backport of core#19190

Test Plan
CC=clang CXX=clang++ cmake .. -DENABLE_SANITIZERS=thread -GNinja
ninja all check check-functional