[Cashtab] Parse token txs in tx history
ClosedPublic
Actions

Authored by bytesofman on Mar 24 2021, 19:12.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4ae0093b9d1b: [Cashtab] Parse token txs in tx history

Summary

Parse and render information about token transctions for tx history

Test Plan

npm start, observe token txs in tx history, check at different widths for responsiveness, confirm rendered info matches explorer output by clicking the tx to view at explorer.be.cash

Diff Detail

Repository

rABC Bitcoin ABC

Branch

txhistory-parse-tokens

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15420
Build 30761: Build Diff	cashtab-tests
Build 30760: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 24 2021, 19:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 24 2021, 19:12

bytesofman requested review of this revision.Mar 24 2021, 19:12

Harbormaster completed remote builds in B15402: Diff 28012.Mar 24 2021, 19:15

Fabien requested changes to this revision.Mar 26 2021, 19:22

Fabien added a subscriber: Fabien.

Fabien added inline comments.

web/cashtab/src/hooks/useBCH.js
197 ↗	(On Diff #28012)	remove
207 ↗	(On Diff #28012)	The token parsing deserves some unit tests
web/cashtab/src/hooks/useWallet.js
203 ↗	(On Diff #28012)	dito
205 ↗	(On Diff #28012)	dito

This revision now requires changes to proceed.Mar 26 2021, 19:22

Add unit tests with mocks for parsing token txs, limit rendered tx count to 5 (api load evident in testing), set rendered tx count as a parameter in Ticker.js

Harbormaster completed remote builds in B15420: Diff 28036.Mar 26 2021, 22:57

Fabien accepted this revision.Mar 27 2021, 15:50

This revision is now accepted and ready to land.Mar 27 2021, 15:50

Closed by commit rABC4ae0093b9d1b: [Cashtab] Parse token txs in tx history (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyMar 27 2021, 16:07

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABC4ae0093b9d1b: [Cashtab] Parse token txs in tx history.