Page MenuHomePhabricator
Differential D9371

[avalanche] delay executing avalanche event loop until IBD is done
ClosedPublic
Actions

Authored by majcosta on Apr 6 2021, 18:49.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCa5c12c9a2c57: [avalanche] delay executing avalanche event loop until IBD is done
Summary

as title

Test Plan
cmake -DCMAKE_BUILD_TYPE=Debug; ninja all check check-functional
build-configurations.py build-tsan

Diff Detail

Event Timeline

majcosta created this revision.Apr 6 2021, 18:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 6 2021, 18:49
majcosta requested review of this revision.Apr 6 2021, 18:49
Harbormaster completed remote builds in B15447: Diff 28077.Apr 6 2021, 19:03
deadalnix requested changes to this revision.Apr 6 2021, 23:30
deadalnix added a subscriber: deadalnix.

Why not just check for IBD status in runEventLoop ? What benefit does all this complication achieves?

This revision now requires changes to proceed.Apr 6 2021, 23:30
deadalnix added inline comments.Apr 6 2021, 23:31
src/eventloop.cpp
31 ↗(On Diff #28077)

This is going to block the scheduler thread for 200ms, why would you ever wan to do that?

majcosta updated this revision to Diff 28080.Apr 7 2021, 15:35

went with simpler

Harbormaster completed remote builds in B15450: Diff 28080.Apr 7 2021, 15:50
deadalnix accepted this revision.Apr 8 2021, 13:07
This revision is now accepted and ready to land.Apr 8 2021, 13:07
Closed by commit rABCa5c12c9a2c57: [avalanche] delay executing avalanche event loop until IBD is done (authored by majcosta). · Explain WhyApr 8 2021, 16:03
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCa5c12c9a2c57: [avalanche] delay executing avalanche event loop until IBD is done.

Revision Contents
Changeset List

PathSize
src/
avalanche/
5 lines

Diff 28080

View Options

src/avalanche/processor.cpp

Loading...