Page MenuHomePhabricator
Differential D9387

[SECP256K1] Add parens around ROUND_TO_ALIGN's parameter.
ClosedPublic
Actions

Authored by Fabien on Apr 8 2021, 13:38.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC9fe733efd8ad: [SECP256K1] Add parens around ROUND_TO_ALIGN's parameter.
Summary
This makes the macro robust against a hypothetical ROUND_TO_ALIGN(foo ?
sizeA : size B) invocation.

Backport of secp256k1#880

Test Plan
ninja check-secp256k1

Diff Detail

Event Timeline

Fabien created this revision.Apr 8 2021, 13:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2021, 13:38
Fabien requested review of this revision.Apr 8 2021, 13:38
teamcity edited the summary of this revision. (Show Details)Apr 8 2021, 13:38
deadalnix requested changes to this revision.Apr 8 2021, 13:47
deadalnix added a subscriber: deadalnix.

The PR in the description is not correct

This revision now requires changes to proceed.Apr 8 2021, 13:47
Fabien requested review of this revision.Apr 8 2021, 13:51
Fabien edited the summary of this revision. (Show Details)

Updated backport link with correct repo

deadalnix accepted this revision.Apr 8 2021, 13:59
This revision is now accepted and ready to land.Apr 8 2021, 13:59
Harbormaster completed remote builds in B15471: Diff 28115.Apr 8 2021, 14:20
Closed by commit rABC9fe733efd8ad: [SECP256K1] Add parens around ROUND_TO_ALIGN's parameter. (authored by Russell O'Connor <roconnor@blockstream.io>, committed by Fabien). · Explain WhyApr 8 2021, 14:29
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC9fe733efd8ad: [SECP256K1] Add parens around ROUND_TO_ALIGN's parameter..

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
2 lines

Diff 28115

View Options

src/secp256k1/src/util.h

Loading...