Paths

Table of Contentst

Differential D9443

[Cashtab] load wallet from storage before calling API
ClosedPublic
Actions

Authored by bytesofman on Apr 23 2021, 15:29.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCb612be7f9aec: [Cashtab] load wallet from storage before calling API

Summary

Reconfigure wallet loading and activation functions to pull directly from local storage (if present) before any API call

Includes unit test to make sure wallet page still loads correctly for users who have not yet opened Cashtab in recent enough version to save wallet.state to local storage. The wallet.state object retains some artefacts to support this edge case legacy user.

Note: some other features I considered adding in this diff but should have their own diff: disable notifications for incoming txs when user switches wallet, make user wallet selection a dropdown from the Wallet page

Test Plan

npm test to confirm new unit tests

npm start and observe wallet loads faster and does not flash incorrect balance before loading
Navigate to settings page and activate a different wallet. Observe activation is almost instant.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

load-before-any-API

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15572
Build 31063: Build Diff	cashtab-tests
Build 31062: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 23 2021, 15:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2021, 15:29

bytesofman requested review of this revision.Apr 23 2021, 15:29

Harbormaster completed remote builds in B15570: Diff 28262.Apr 23 2021, 15:31

Removing comments used in development, marking mock as generated

Harbormaster completed remote builds in B15571: Diff 28263.Apr 23 2021, 15:35

Removing obsolete dev comment

Harbormaster completed remote builds in B15572: Diff 28264.Apr 23 2021, 15:39

Handle case of cashtab user loading with unmigrated wallets, ensure that wallet object state is kept current

Harbormaster completed remote builds in B15580: Diff 28272.Apr 26 2021, 15:11

Allow useEffect call to update savedWallets list in Configure.js; do not call it twice with the previous wallet

Harbormaster completed remote builds in B15581: Diff 28273.Apr 26 2021, 20:19

Fabien accepted this revision.Apr 27 2021, 15:30

This revision is now accepted and ready to land.Apr 27 2021, 15:30

Closed by commit rABCb612be7f9aec: [Cashtab] load wallet from storage before calling API (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyApr 27 2021, 15:39

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABCb612be7f9aec: [Cashtab] load wallet from storage before calling API.

bytesofman mentioned this in D9451: [Cashtab] Use wallet.state for balance on Send screen.Apr 28 2021, 12:43

Joey King <joseph.roy.king@gmail.com> mentioned this in rABCc32043f396be: [Cashtab] Use wallet.state for balance on Send screen.Apr 29 2021, 11:36

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Wallet/

35 lines

__mocks__/

walletAndBalancesMock.js

__tests__/

28 lines

__snapshots__/

Wallet.test.js.snap

hooks/

37 lines

Diff 28264

web/cashtab/src/components/Wallet/Wallet.js

Loading...

web/cashtab/src/components/Wallet/mocks/walletAndBalancesMock.js

Loading...

web/cashtab/src/components/Wallet/tests/Wallet.test.js

Loading...

web/cashtab/src/components/Wallet/tests/snapshots/Wallet.test.js.snap

Loading...

web/cashtab/src/hooks/useWallet.js

Loading...