Differential D9576

Add missing <optional> headers
ClosedPublic
Actions

Authored by Fabien on May 25 2021, 07:57.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCf7e0e1df575d: Add missing <optional> headers

Summary

This is a leftover from D8494: when switching from boost::optional to
std::optional the headers were not updated.

Also added a missing <limits> include in the FuzzDataProvider.h that
supposedly was pulled indirectly. Note that <climits> cannot be removed
due to CHAR_BIT.

Test Plan

On an up-to-date archlinux:

ninja all check
ninja bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Branch

add_missing_optional

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15795
Build 31490: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang · build-fuzzer · build-diff · build-debug · build-bench · build-clang-tidy
Build 31489: arc lint + arc unit

Event Timeline

Fabien created this revision.May 25 2021, 07:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2021, 07:57

Fabien requested review of this revision.May 25 2021, 07:57

Harbormaster completed remote builds in B15795: Diff 28589.May 25 2021, 08:15

PiRK accepted this revision.May 25 2021, 08:30

This revision is now accepted and ready to land.May 25 2021, 08:30

Closed by commit rABCf7e0e1df575d: Add missing <optional> headers (authored by Fabien). · Explain WhyMay 25 2021, 08:46

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf7e0e1df575d: Add missing <optional> headers.

Revision Contents
Changeset List

Path

Size

src/

bench/

wallet_balance.cpp

7 lines

1 line

node/

2 lines

2 lines

script/

1 line

test/

fuzz/

FuzzedDataProvider.h

1 line

1 line

1 line

1 line

util/

1 line

wallet/

2 lines

coinselection.cpp

2 lines

2 lines

1 line

Diff 28589

src/bench/wallet_balance.cpp

Loading...

src/miner.h

Loading...

src/node/psbt.h

Loading...

src/psbt.h

Loading...

src/script/descriptor.h

Loading...

src/test/fuzz/FuzzedDataProvider.h

Loading...

src/test/fuzz/util.h

Loading...

src/test/util_tests.cpp

Loading...

src/txmempool.h

Loading...

src/util/system.h

Loading...

src/wallet/coincontrol.h

Loading...

src/wallet/coinselection.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/wallet.h

Loading...