Page MenuHomePhabricator
Differential D9602

refactor: Remove unused BlockAssembler::pblock member var
ClosedPublic
Actions

Authored by PiRK on May 28 2021, 14:30.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC0fb5b7364afe: refactor: Remove unused BlockAssembler::pblock member var
Summary

The difference in BlockAssembler::AddToBlock is explained by D2047:
the Bitcoin ABC codebase stores the CTransactionRef in a CBlockTemplateEntry struct, and copies it into the block later in BlockAssembler::CreateNewBlock

This is a backport of core#19283

Test Plan

ninja check-functional

Diff Detail

Event Timeline

PiRK created this revision.May 28 2021, 14:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2021, 14:30
PiRK requested review of this revision.May 28 2021, 14:30
teamcity edited the summary of this revision. (Show Details)May 28 2021, 14:30
Harbormaster completed remote builds in B15845: Diff 28664.May 28 2021, 14:41
deadalnix requested changes to this revision.May 28 2021, 15:10
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/miner.cpp
131 ↗(On Diff #28664)

That change isn't part of the PR and not really an improvement.

This revision now requires changes to proceed.May 28 2021, 15:10
PiRK updated this revision to Diff 28665.May 28 2021, 15:21

restore the comment as is was in the ABC codebase

Harbormaster completed remote builds in B15846: Diff 28665.May 28 2021, 15:34
deadalnix accepted this revision.May 31 2021, 15:14
This revision is now accepted and ready to land.May 31 2021, 15:14
Closed by commit rABC0fb5b7364afe: refactor: Remove unused BlockAssembler::pblock member var (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyMay 31 2021, 20:00
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC0fb5b7364afe: refactor: Remove unused BlockAssembler::pblock member var.

Revision Contents
Changeset List

PathSize
src/
2 lines
2 lines

Diff 28665

View Options

src/miner.h

Loading...
View Options

src/miner.cpp

Loading...