Differential D9667

[avalanche] Capitalize the init error messages and add a dot
ClosedPublic
Actions

Authored by Fabien on Jun 11 2021, 11:39.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCaa0cd148c4a4: [avalanche] Capitalize the init error messages and add a dot

Summary

This makes the error messages more consistent with others from our
codebase.

Ref T1635.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_init_error_capitalize

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15977
Build 31853: Build Diff	lint-circular-dependencies · build-clang-tidy · build-without-wallet · build-diff · build-clang · build-debug
Build 31852: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 11 2021, 11:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 11 2021, 11:39

Fabien requested review of this revision.Jun 11 2021, 11:39

Harbormaster completed remote builds in B15977: Diff 28862.Jun 11 2021, 11:52

majcosta accepted this revision.Jun 11 2021, 12:09

This revision is now accepted and ready to land.Jun 11 2021, 12:09

Fabien added a child revision: D9668: [avalanche] Check the return value of the delegation addLevel() at startup.Jun 11 2021, 12:29

Closed by commit rABCaa0cd148c4a4: [avalanche] Capitalize the init error messages and add a dot (authored by Fabien). · Explain WhyJun 11 2021, 12:45

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCaa0cd148c4a4: [avalanche] Capitalize the init error messages and add a dot.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.cpp

18 lines

test/

functional/

abc_rpc_avalancheproof.py

18 lines

Diff 28862

View Options

src/avalanche/processor.cpp