Paths

Table of Contentst

Differential D9689

[tests] Remove unnecessary cs_mains in denialofservice_tests
ClosedPublic
Actions

Authored by PiRK on Jun 16 2021, 16:07.

Tags

None

Subscribers

None

Tokens

"Haypence" token, awarded by teamcity.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC41a27535979f: [tests] Remove unnecessary cs_mains in denialofservice_tests

Summary

9fdf05d70cac4a62d1aeeb4299e2c3a9a866f8af (D3606) resolved some lock
inversion warnings in denialofservice_tests, but left in a number
of cs_main locks that are unnecessary (introducing lock inversion
warnings in future changes).

This is a backport of core#19533

Test Plan

with TSAN:
ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19533

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16026
Build 31948: Build Diff	lint-circular-dependencies · build-debug · build-diff · build-without-wallet · build-clang-tidy · build-clang
Build 31947: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 16 2021, 16:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 16 2021, 16:07

PiRK requested review of this revision.Jun 16 2021, 16:07

teamcity edited the summary of this revision. (Show Details)Jun 16 2021, 16:07

@bot build-tsan

teamcity awarded a token.Jun 16 2021, 16:10

Harbormaster completed remote builds in B16026: Diff 28939.Jun 16 2021, 16:22

majcosta accepted this revision.Jun 16 2021, 17:41

This revision is now accepted and ready to land.Jun 16 2021, 17:41

Closed by commit rABC41a27535979f: [tests] Remove unnecessary cs_mains in denialofservice_tests (authored by Matt Corallo <git@bluematt.me>, committed by PiRK). · Explain WhyJun 17 2021, 07:33

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC41a27535979f: [tests] Remove unnecessary cs_mains in denialofservice_tests.

Revision Contents
Changeset List

Path

Size

src/

test/

denialofservice_tests.cpp

18 lines

Diff 28939

src/test/denialofservice_tests.cpp

Loading...