Paths

Table of Contentst

Differential D9782

[cashtab-components] rebrand support
ClosedPublic
Actions

Authored by bytesofman on Jul 13 2021, 22:53.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe982001851d6: [cashtab-components] rebrand support

Summary

XEC support for cashtab react components.

Test Plan

cd web/cashtab-components
npm run storybook

Click button under CashtabBadge (price in fiat) to verify extension opens with XEC transaction of correct amount
Click button under CashtabBadge (price in eToken) to verify that extension DOES NOT open

Diff Detail

Repository

rABC Bitcoin ABC

Branch

upgrading-components

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16173
Build 32219: Build Diff	cashtab-components-tests
Build 32218: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 13 2021, 22:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 13 2021, 22:53

bytesofman requested review of this revision.Jul 13 2021, 22:53

Harbormaster completed remote builds in B16173: Diff 29173.Jul 13 2021, 22:55

This still uses the old address prefix

This revision now requires changes to proceed.Jul 15 2021, 08:56

Replace bitcoincash: and simpleledger: addresses with ecash: and etoken:

Harbormaster completed remote builds in B16190: Diff 29201.Jul 15 2021, 14:13

Fabien requested changes to this revision.Jul 15 2021, 14:36

Fabien added inline comments.

web/cashtab-components/src/hoc/CashtabBase/CashtabBase.tsx
184 ↗	(On Diff #29201)	This seems unrelated to the changes, and maybe deserve a meaningful error message ?
209 ↗	(On Diff #29201)	I suppose it's not needed because it's a lib ? In any case this doesn't belong to this patch

This revision now requires changes to proceed.Jul 15 2021, 14:36

bytesofman added inline comments.Jul 15 2021, 15:55

web/cashtab-components/src/hoc/CashtabBase/CashtabBase.tsx
184 ↗	(On Diff #29201)	will include in separate diff
209 ↗	(On Diff #29201)	will move to separate diff

Remove changes unrelated to this diff

Harbormaster completed remote builds in B16196: Diff 29207.Jul 15 2021, 15:59

Fabien accepted this revision.Jul 16 2021, 11:29

This revision is now accepted and ready to land.Jul 16 2021, 11:29

Closed by commit rABCe982001851d6: [cashtab-components] rebrand support (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyJul 16 2021, 16:26

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABCe982001851d6: [cashtab-components] rebrand support.

Revision Contents
Changeset List

Path

Size

web/

cashtab-components/

8 lines

6 lines

public/

cashtab-components.png

src/

atoms/

Ticker/

18 lines

components/

PriceDisplay/

PriceDisplay.stories.tsx

2 lines

hoc/

CashtabBase/

CashtabBase.tsx

29 lines

images/

12-bitcoin-cash-square-crop.svg

bitcoin-cash-logo.svg

bitcoin-cash.svg

logo_primary.png

logo_secondary.png

simple-ledger-protocol-logo.png

styles/

12 lines

utils/

cashtab-helpers.ts

13 lines

Diff 29173

web/cashtab-components/README.md

Loading...

web/cashtab-components/package.json

Loading...

web/cashtab-components/public/cashtab-components.png

Loading...

web/cashtab-components/public/favicon.ico

Loading...

web/cashtab-components/src/atoms/Ticker/Ticker.tsx

Loading...

web/cashtab-components/src/components/PriceDisplay/PriceDisplay.stories.tsx

Loading...

web/cashtab-components/src/hoc/CashtabBase/CashtabBase.tsx

Loading...

web/cashtab-components/src/images/12-bitcoin-cash-square-crop.svg

Loading...

web/cashtab-components/src/images/bitcoin-cash-logo.svg

Loading...

web/cashtab-components/src/images/bitcoin-cash.svg

Loading...

web/cashtab-components/src/images/logo_primary.png

Loading...

web/cashtab-components/src/images/logo_secondary.png

Loading...

web/cashtab-components/src/images/simple-ledger-protocol-logo.png

Loading...

web/cashtab-components/src/images/slp-logo.png

Loading...

web/cashtab-components/src/styles/colors.js

Loading...

web/cashtab-components/src/utils/cashtab-helpers.ts

Loading...