Page MenuHomePhabricator
Differential D9783

rpc: Avoid useless mempool query in gettxoutproof
ClosedPublic
Actions

Authored by PiRK on Jul 14 2021, 07:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd23ae6f6ee5a: rpc: Avoid useless mempool query in gettxoutproof
Summary

GetTransaction implicitly and unconditionally asks the mempool global for a transaction. This is problematic for several reasons:

  • gettxoutproof is for on-chain txs only and asking the mempool for on-chain txs is confusing and minimally wasteful
  • Globals are confusing and make code harder to test with unit tests

Fix both issues by passing in an optional mempool. This also helps with core#19556

This is a backport of core#19589

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Jul 14 2021, 07:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 14 2021, 07:55
PiRK requested review of this revision.Jul 14 2021, 07:55
teamcity edited the summary of this revision. (Show Details)Jul 14 2021, 07:55
Harbormaster completed remote builds in B16174: Diff 29174.Jul 14 2021, 08:10
Fabien added a subscriber: Fabien.Jul 15 2021, 09:06

@bot build-master

src/validation.h
244 ↗(On Diff #29174)

txid

teamcity awarded a token.Jul 15 2021, 09:06
PiRK added a child revision: D9788: Remove mempool global from init.Jul 15 2021, 09:10
PiRK updated this revision to Diff 29183.Jul 15 2021, 09:21

hash -> txid in GetTransaction function documentation

Fabien accepted this revision.Jul 15 2021, 09:35
This revision is now accepted and ready to land.Jul 15 2021, 09:35
This revision was landed with ongoing or failed builds.Jul 15 2021, 09:48
Closed by commit rABCd23ae6f6ee5a: rpc: Avoid useless mempool query in gettxoutproof (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain Why
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCd23ae6f6ee5a: rpc: Avoid useless mempool query in gettxoutproof.
Harbormaster completed remote builds in B16182: Diff 29183.Jul 15 2021, 09:50

Revision Contents
Changeset List

PathSize
src/
40 lines
rpc/
15 lines
23 lines
46 lines

Diff 29183

View Options

src/rest.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...