After seeing a request for Vietnamese dong support, figured might as well add a few more based on traffic source for Cashtab users. I removed the order-of-magnitude sanity check on price as this was broken by Vietnamese Dong and also CoinGecko is keeping the BCHA api separate from the XEC one, so there is no longer the risk of a sudden switch.
Details
Details
- Reviewers
majcosta - Group Reviewers
Restricted Project - Commits
- rABCb1388bab869b: [Cashtab] add support for additional fiat currencies
Review new currencies to make sure no typos. Cycle through a few and try to break the app. There is a known issue where the UI does not fully lock on currency change, so if you quickly switch to another currency it may display improperly. A task is open for this and it will be addressed in another diff.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- adding-more-fiat-currencies
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 16276 Build 32419: Build Diff cashtab-tests Build 32418: arc lint + arc unit
Event Timeline
Comment Actions
if you could also please split this diff in two, that's better; adding new fiat currencies isn't related to reverting the precaution in D9718.
| web/cashtab/src/hooks/useWallet.js | ||
|---|---|---|
| 1344–1349 ↗ | (On Diff #29336) | this should be changed too, no? at least according to D9718 |