[Cashtab] Lock full UI when utxo set is loading after send
ClosedPublic
Actions

Authored by bytesofman on Aug 12 2021, 22:59.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCe0c13cd522af: [Cashtab] Lock full UI when utxo set is loading after send

Summary

T1720

Right now the app is set to lock the UI on the Send and SendToken screens while the utxo set is refreshing. However, the user may still click off the Send or SendToken screen and then navigate back. This could allow the user to send a transaction with an invalid utxo set. The transaction won't actually send, they will get an error msg, but it's confusing and not great UX.

This diff locks the nav bar while the utxo set refreshes.

Test Plan

npm start, send an XEC transaction, notice that the nav bar is locked, send an eToken transaction, notice the nav bar is locked

Diff Detail

Repository

rABC Bitcoin ABC

Branch

universal-app-loading-param

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16325
Build 32513: Build Diff	cashtab-tests
Build 32512: arc lint + arc unit

Event Timeline

bytesofman created this revision.Aug 12 2021, 22:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 12 2021, 22:59

bytesofman requested review of this revision.Aug 12 2021, 22:59

Harbormaster completed remote builds in B16313: Diff 29395.Aug 12 2021, 23:01

Fabien requested changes to this revision.Aug 13 2021, 07:17

Fabien added a subscriber: Fabien.

Fabien added inline comments.

web/cashtab/src/components/Send/Send.js
554 ↗	(On Diff #29395)	Looks like debug stuff that needs to be removed
web/cashtab/src/components/Send/SendToken.js
451 ↗	(On Diff #29395)	Dito
web/cashtab/src/components/Send/__tests__/Send.test.js
120 ↗	(On Diff #29395)	?

This revision now requires changes to proceed.Aug 13 2021, 07:17

bytesofman requested review of this revision.Aug 13 2021, 16:01

bytesofman added inline comments.

web/cashtab/src/components/Send/Send.js
554 ↗	(On Diff #29395)	This was necessary to pass the unit tests in `Send.test.js`. Otherwise, the `<Send/>` component receives to prop for this, lacks a default, and will throw a `passLoadingStatus is not a function` error. I chose `status => {console.log(status)}` as a simple function that passes a parameter. It is only used in the unit tests.
web/cashtab/src/components/Send/SendToken.js
451 ↗	(On Diff #29395)	Same as previous reply. Ultimately, every component will need to have this kind of props validation. It's an oversight that it is not universally included; task is open for it. This one is a bit weird since the default is just a stub function that is only ever used in the unit tests.
web/cashtab/src/components/Send/__tests__/Send.test.js
120 ↗	(On Diff #29395)	Looks like this is leftover from some of the alternative approaches I tried to help the unit tests recognize the `passLoadingStatus` param, will take it out.

Removing space change

Harbormaster completed remote builds in B16322: Diff 29404.Aug 13 2021, 16:05

Fabien added inline comments.Aug 13 2021, 17:58

web/cashtab/src/components/Send/Send.js
554 ↗	(On Diff #29395)	OK, can you add a comment in the code to explain this ? This is far from obvious and will prevent from getting cleaned up unexpectedly.