Page MenuHomePhabricator

[Cashtab] Fix bug where new user sees permanent loading screen
ClosedPublic

Authored by bytesofman on Aug 21 2021, 15:41.

Details

Summary

T1752

In standardizing the wallet loading screeen to lock the entire app UI instead of screen by screen, I neglected the case of a new user with no created wallet.

This user will see a perpetual loading screen since wallet === false and therefore validWallet will always be false.

This diff handles this case in the App.js spinner.

Test Plan

npm start
Load in an incognito window or browser with no cashtab wallet
Observe that the app does load
Create a wallet
Send a tx and verify the app locks UI for loading and then unlocks when utxo set is refreshed

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch-no-wallet-loading-bug
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16357
Build 32577: Build Diffcashtab-tests
Build 32576: arc lint + arc unit