refactor: Make CScriptVisitor stateless
ClosedPublic
Actions

Authored by PiRK on Aug 25 2021, 14:30.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCa112f4d8d3fe: refactor: Make CScriptVisitor stateless

Summary

CScriptVisitor was added in core#1357 and the visitor return type was never used. Now CScriptVisitor is stateless and CScript is the return type.

This is a backport of core#18863

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16417
Build 32697: Build Diff	lint-circular-dependencies · build-clang-tidy · build-clang · build-debug · build-without-wallet · build-diff
Build 32696: arc lint + arc unit

Event Timeline

PiRK created this revision.Aug 25 2021, 14:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 25 2021, 14:30

PiRK requested review of this revision.Aug 25 2021, 14:30

teamcity edited the summary of this revision. (Show Details)Aug 25 2021, 14:31

PiRK edited the summary of this revision. (Show Details)Aug 25 2021, 14:33

Harbormaster completed remote builds in B16417: Diff 29560.Aug 25 2021, 14:44

majcosta accepted this revision.Aug 26 2021, 07:13

This revision is now accepted and ready to land.Aug 26 2021, 07:13

Closed by commit rABCa112f4d8d3fe: refactor: Make CScriptVisitor stateless (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyAug 26 2021, 08:27

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCa112f4d8d3fe: refactor: Make CScriptVisitor stateless.

Revision Contents
Changeset List

Path

Size

src/

script/

standard.cpp

34 lines

Diff 29560

View Options

refactor: Make CScriptVisitor statelessClosedPublicActions