Chainparams: Use a regular factory for creating chainparams
ClosedPublic
Actions

Authored by deadalnix on Feb 24 2018, 10:24.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGbf8c99cadd56: Chainparams: Use a regular factory for creating chainparams
rABCbf8c99cadd56: Chainparams: Use a regular factory for creating chainparams

Summary

Backport core's PR8855

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chainparamsfactory

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1921
Build 2000: Bitcoin ABC Buildbot (legacy)
Build 1999: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 24 2018, 10:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 24 2018, 10:24

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix added a child revision: D1130: Allow setting nMinimumChainWork on command line.Feb 24 2018, 10:36

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1921: Diff 2967.Feb 24 2018, 10:46

jasonbcox accepted this revision.Feb 24 2018, 15:30

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/init.cpp
318	At first glance, CreateChainParams and CreateBaseChainParams look the same. We should clarify the differences in the future, but I think that's outside the scope of this diff.

This revision is now accepted and ready to land.Feb 24 2018, 15:30

Closed by commit rABCbf8c99cadd56: Chainparams: Use a regular factory for creating chainparams (authored by Jorge Timón <jtimon@jtimon.cc>, committed by deadalnix). · Explain WhyFeb 24 2018, 18:28

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

7 lines

19 lines

38 lines

17 lines

24 lines

11 lines

10 lines

55 lines

qt/

paymentserver.cpp

12 lines

test/

bitcoinaddressvalidatortests.cpp

3 lines

guiutiltests.cpp

6 lines

uritests.cpp

15 lines

test/

cashaddrenc_tests.cpp

55 lines

10 lines

13 lines

9 lines

28 lines

versionbits_tests.cpp

8 lines

Diff 2967

View Options

src/bitcoin-cli.cpp

View Options

src/chainparams.h

View Options

src/chainparams.cpp

View Options

src/chainparamsbase.h

View Options

src/chainparamsbase.cpp

View Options

src/config.h

View Options

src/config.cpp

View Options

src/init.cpp

View Options

src/qt/paymentserver.cpp

View Options

src/qt/test/bitcoinaddressvalidatortests.cpp

View Options

src/qt/test/guiutiltests.cpp

View Options

src/qt/test/uritests.cpp

View Options

src/test/cashaddrenc_tests.cpp

View Options

src/test/dstencode_tests.cpp

View Options

src/test/main_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/pow_tests.cpp

View Options

src/test/versionbits_tests.cpp

Chainparams: Use a regular factory for creating chainparamsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2967

src/bitcoin-cli.cpp

src/chainparams.h

src/chainparams.cpp

src/chainparamsbase.h

src/chainparamsbase.cpp

src/config.h

src/config.cpp

src/init.cpp

src/qt/paymentserver.cpp

src/qt/test/bitcoinaddressvalidatortests.cpp

src/qt/test/guiutiltests.cpp

src/qt/test/uritests.cpp

src/test/cashaddrenc_tests.cpp

src/test/dstencode_tests.cpp

src/test/main_tests.cpp

src/test/miner_tests.cpp

src/test/pow_tests.cpp

src/test/versionbits_tests.cpp

Chainparams: Use a regular factory for creating chainparams
ClosedPublic
Actions

Revision Contents
Changeset List