Page MenuHomePhabricator
Differential D10074

rpc: document returned error fields as optional if applicable
ClosedPublic
Actions

Authored by PiRK on Sep 8 2021, 14:13.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC1241ef50e90d: rpc: document returned error fields as optional if applicable
Summary

Affects the following RPCs:

  • analyzepsbt
  • signrawtransactionwithkey
  • signrawtransactionwithwallet

We do not have the estimate(smart|raw)fee RPCs to update.

This is a backport of core#19644

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Sep 8 2021, 14:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 8 2021, 14:13
PiRK requested review of this revision.Sep 8 2021, 14:13
teamcity edited the summary of this revision. (Show Details)Sep 8 2021, 14:13
Harbormaster completed remote builds in B16589: Diff 29855.Sep 8 2021, 14:24
majcosta requested changes to this revision.Sep 8 2021, 15:40
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/rpc/rawtransaction.cpp
2068 ↗(On Diff #29855)
This revision now requires changes to proceed.Sep 8 2021, 15:40
PiRK updated this revision to Diff 29859.Sep 8 2021, 16:07

add parentheses

Harbormaster completed remote builds in B16593: Diff 29859.Sep 8 2021, 16:21
majcosta accepted this revision.Sep 10 2021, 15:37
This revision is now accepted and ready to land.Sep 10 2021, 15:37
Closed by commit rABC1241ef50e90d: rpc: document returned error fields as optional if applicable (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhySep 10 2021, 16:40
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC1241ef50e90d: rpc: document returned error fields as optional if applicable.

Revision Contents
Changeset List

PathSize
src/
rpc/
5 lines
wallet/
1 line

Diff 29859

View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...