Page MenuHomePhabricator
Differential D10075

remove argName nBlocks from estimatefee RPC command registration
ClosedPublic
Actions

Authored by PiRK on Sep 8 2021, 14:19.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC4a106b29a689: remove argName nBlocks from estimatefee RPC command registration
Summary

Our version of estimatefee does not take a number of blocks as an
argument. It just returns a constant value, and the transaction is
always expected to be in the next block.

Test Plan

ninja all check-all

$ ./src/bitcoin-cli estimatefee 6
error code: -1
error message:
estimatefee

Estimates the approximate fee per kilobyte needed for a transaction

Result:
n    (numeric) estimated fee-per-kilobyte

Examples:
> bitcoin-cli estimatefee

../test/lint/check-rpc-mappings.py ..

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 8 2021, 14:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 8 2021, 14:19
Harbormaster completed remote builds in B16590: Diff 29856.Sep 8 2021, 14:19
PiRK requested review of this revision.Sep 8 2021, 14:19
majcosta requested changes to this revision.Sep 8 2021, 15:41
majcosta added a subscriber: majcosta.

linter be mad

This revision now requires changes to proceed.Sep 8 2021, 15:41
PiRK updated this revision to Diff 29858.Sep 8 2021, 16:02

remove the arg also from vRPCConvertParams

PiRK edited the test plan for this revision. (Show Details)Sep 8 2021, 16:03
Harbormaster completed remote builds in B16592: Diff 29858.Sep 8 2021, 16:14
majcosta accepted this revision.Sep 10 2021, 15:38
This revision is now accepted and ready to land.Sep 10 2021, 15:38
Closed by commit rABC4a106b29a689: remove argName nBlocks from estimatefee RPC command registration (authored by PiRK). · Explain WhySep 13 2021, 15:38
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4a106b29a689: remove argName nBlocks from estimatefee RPC command registration.

Revision Contents
Changeset List

PathSize
src/
rpc/
1 line
2 lines

Diff 29913

View Options

src/rpc/client.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...